Error in libpq docs for target_session_attrs, prefer-standby mode

Started by Greg Nancarrowover 4 years ago3 messages
#1Greg Nancarrow
gregn4422@gmail.com
1 attachment(s)

Hi,

I spotted an error in the development version documentation for
libpq's connection parameter "target_session_attrs" (34.1.2 Parameter
Key Words).
In the description for the "prefer-standby" mode, it says "... but if
none of the listed hosts is a standby server, try again in all mode".
There is no such "all" mode. It should instead say "any" mode.
Patch is attached.

Regards,
Greg Nancarrow
Fujitsu Australia

Attachments:

libpq_target_session_attrs_doc_fix.patchapplication/octet-stream; name=libpq_target_session_attrs_doc_fix.patchDownload
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 7bcb7504a6..174a6b7f37 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -1965,7 +1965,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
           <listitem>
            <para>
             first try to find a standby server, but if none of the listed
-            hosts is a standby server, try again in <literal>all</literal>
+            hosts is a standby server, try again in <literal>any</literal>
             mode
            </para>
           </listitem>
#2Laurenz Albe
laurenz.albe@cybertec.at
In reply to: Greg Nancarrow (#1)
Re: Error in libpq docs for target_session_attrs, prefer-standby mode

On Wed, 2021-04-28 at 12:55 +1000, Greg Nancarrow wrote:

I spotted an error in the development version documentation for
libpq's connection parameter "target_session_attrs" (34.1.2 Parameter
Key Words).
In the description for the "prefer-standby" mode, it says "... but if
none of the listed hosts is a standby server, try again in all mode".
There is no such "all" mode. It should instead say "any" mode.
Patch is attached.

You are right, and the patch is good.

Yours,
Laurenz Albe

#3Michael Paquier
michael@paquier.xyz
In reply to: Laurenz Albe (#2)
Re: Error in libpq docs for target_session_attrs, prefer-standby mode

On Wed, Apr 28, 2021 at 01:32:05PM +0200, Laurenz Albe wrote:

You are right, and the patch is good.

Thanks, fixed.
--
Michael