Dec 2024

1 commit
Backpatch critical performance fixes to pgarch.c
12 Dec 2024Álvaro HerreraREL_14_STABLE14.16Also in: Strange path from pgarch_readyXlog() (written from the discussion, no matching patch)
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #1051 of 3 reviewers saw the final version

This combined backpatch incorporates the batching implementation from #105, including the 64-file heap, cached-status checks, and timeline-history notifications. The MAX_XFN_CHARS + 1 buffers, allocated archiver state, and binaryheap_reset() in src/backend/postmaster/pgarch.c come from thread #45300, consistent with that thread's verdict attributing its contribution to discussion.

  • Robert Haassaw an earlier versionLLM analysis, 99% sureIdentified the missing cached-status rechecks in #64 and committed the final batching attachment in #111, before the buffer and workspace changes incorporated into this backpatch.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 94% sureExamined the batching patch's 64-file limit and remaining quadratic scanning cost in #80, before the later buffer and state-management changes.
  • Álvaro Herrerasaw the final versioncommittercommitted the patch

Nov 2021

1 commit
Improve performance of pgarch_readyXlog() with many status files.
11 Nov 2021Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #1052 of 4 reviewers saw the final version

All added and removed lines match #105, including the 64-file heap, cached-status stat() checks, and PgArchForceDirScan() integration across the same three files. Robert Haas confirms committing the final attachment in #111.

  • Andres Freundsaw an earlier versionLLM analysis, 87% sureProposed collecting multiple filenames per directory scan and identified archive commands that modify status files in #2, before the implementation and its revisions.
  • Kyotaro Horiguchisaw the final versionLLM analysis, 92% sureCritiqued the batching alternative's 64-file limit and complexity in #80 and accepted its performance benefit in #86, with only comment changes subsequently reported for #105.
  • David Steelesaw an earlier versionLLM analysis, 79% sureRead and approved the batching proposal in #104, replying to the initial batching patch named in #103; conservatively, this predates the cached-status rechecks in the final implementation.
  • Robert Haassaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Nathan BossartLLM2
Reviewer
Alvaro Herreracommitter1
Robert Haascommitter1
Committer
Alvaro Herrera1
Robert Haas1

N LLM means N of the credits come from LLM analysis, not from commit trailers.