May 2021

2 commits
Rename the logical replication global "wrconn"
12 May 2021Alvaro Herreramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.4+3 more
LLM analysis, 100% surelanded as postedfrom patchset #222 of 2 reviewers saw the final version

The four-file rename diff matches #22 exactly apart from index identifiers and hunk offsets. Although Alvaro sent that version, its From header and the commit credit Peter Smith as author.

  • Tom Lanesaw the final versionLLM analysis, 91% sureIn #17, Tom assessed the rename in #11, supported separating it from the bugfix, and advocated the adopted backpatching policy; subsequent rename changes were cosmetic.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
AlterSubscription_refresh: avoid stomping on global variable
7 May 2021Alvaro Herreramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.3+3 moreAlso in: Segfault when a replica trigger tries to refresh subscription
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #183 of 3 reviewers saw the final version

Commits the subscriptioncmds.c bugfix portion of #18, leaving the global rename for later, and additionally removes a redundant NULL initializer in DropSubscription. The linked thread #70384 supplied the earlier crash report but has no competing patchset.

  • Bharath Rupireddysaw the final versiontrailerBharath reported passing regression tests and suggested commit wording in #2, then discussed connection cleanup and requested wording fixes in #15; the committed bugfix differs only lightly.
  • Japin Lisaw the final versiontrailerJapin questioned moving walrcv_connect outside PG_TRY in #12 and acknowledged Peter's explanation in #14; that implementation remained in the committed bugfix.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Peter Smith1
Peter.B.Smith@fujitsu.com1
Reviewer
Alvaro Herreracommitter2
Bharath Rupireddy1
Japin Li1
Committer
Alvaro Herrera2