Nov 2021

2 commits
Remove tests added by bd807be6935929bdefe74d1258ca08048f0aafa3.
7 Nov 2021Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Reverses exactly the test-file changes introduced by bd807be693, retaining the amcheck checks. No attachment proposes this removal; it follows Tom Lane's buildfarm report #17 and Mark Dilger's confirmation #18.

  • Tom Lanesaw the final versionLLM analysis, 99% sureReported unstable buildfarm test output from #15 in #17, prompting the test removal.
  • Mark Dilgersaw the final versionLLM analysis, 94% sureInvestigated the failures and confirmed that the tests themselves were faulty in #18, supporting Robert Haas's subsequent removal.
amcheck: Add additional TOAST pointer checks.
5 Nov 2021Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #155 of 5 reviewers saw the final version

The complete diff matches #15 after ignoring index-hash abbreviation, including all checks in contrib/amcheck/verify_heapam.c and both new tests. Robert Haas confirmed committing that version in #16.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureIdentified misleading comment wording in #2, corrected in #3, with only light changes afterward.
  • Aleksander Alekseevsaw the final versionLLM analysis, 100% sureDeclared the patch ready for committer in #4 and clarified in #5 that the failure checkboxes were accidental.
  • Heikki Linnakangassaw the final versionLLM analysis, 99% sureExamined the maximum-size invariant in #6 and was explicitly credited as a reviewer in bd807be693.
  • Greg Starksaw the final versionLLM analysis, 100% sureFound the patch committable in #9 and accepted the switch structure's compiler-diagnostic rationale in #11, with only light changes afterward.
  • Robert Haassaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Mark DilgerLLM1
Reviewer
Robert Haascommitter1
Committer
Robert Haas2

N LLM means N of the credits come from LLM analysis, not from commit trailers.