model-writtenrun 7478 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- 盏一 proposed removing ProcArrayRemove()'s search loop because proc->pgxactoff already identifies the process's position in the dense array #1.
- Andres Freund requested a patch with assertion-only duplicate checking and suggested landing the simplification before PostgreSQL 14 beta to ease maintenance; Tom Lane supported the simplification but considered duplicate searching unnecessary, while Andres recalled related bugs during development #2 #3 #4.
- Andrew Dunstan asked whether the change should become an open item, and 盏一 supplied a patch using the stored offset, correcting existing assertions, and adding assertion-only helpers to check the position and absence of duplicates #5 #6.
- Andres committed an edited version as d8e950d3ae, retaining the simplification while placing assertions in existing array loops, adjusting offset assignments, and cleaning up the memmove calls; his announcement explained the broader assertion coverage and retained authorship credit #7.
- 盏一 acknowledged the committed changes and authorship handling, leaving the proposed simplification landed with no outstanding work identified in the thread #8.