Jun 2021

1 commit
Prepare for forthcoming LLVM 13 API change.
24 Jun 2021Thomas Munromaster14beta3REL_19_STABLE14beta3REL_18_STABLE14beta3REL_17_STABLE14beta3REL_16_STABLE14beta3REL_15_STABLE14beta3REL_14_STABLE14beta3REL_13_STABLE13.4+2 more
LLM analysis, 100% surelanded as postedfrom patchset #282 of 2 reviewers saw the final version

The commit reproduces all three added lines from #28 in src/backend/jit/llvm/llvmjit.c, retaining each symbol-string entry under LLVM_VERSION_MAJOR > 12. Only the commit title and explanatory message were expanded 9b4e4cfe66.

  • Andres Freundsaw the final versionLLM analysis, 98% sureHe proposed moving the retain into the earlier loop before ownership transfer, which the attached patch adopted, and subsequently supported immediate backpatching #26 #28 #31.
  • Tom Lanesaw the final versionLLM analysis, 94% sureHe questioned whether compile-time version detection was reliable and then endorsed shipping the attached fix proactively because crashes were worse than the potential leak #25 #29.

Credits across 1 commit

Author
Thomas MunroLLM1
Committer
Thomas Munro1

N LLM means N of the credits come from LLM analysis, not from commit trailers.