May 2021

1 commit
Simplify one use of ScanKey in pg_subscription.c
12 May 2021Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #14 of 4 reviewers saw the final version

The committed diff exactly matches #1: it changes skey[2] to skey[1], removes nkeys, initializes skey[0], and passes a constant key count of 1 in src/backend/catalog/pg_subscription.c. Michael Paquier confirmed application in #9.

  • Tom Lanesaw the final versiontrailerTom supported retaining the one-element array to minimize the change in #7, and the patch landed unchanged.
  • Julien Rouhaudsaw the final versiontrailerJulien supported considering a scalar key in #3 and compared existing scalar and array usage in #5, reviewing the patch that ultimately landed unchanged.
  • Bharath Rupireddysaw the final versiontrailerBharath traced the apparent copy-and-paste error and questioned the one-element array declaration in #2, reviewing the patch that landed unchanged.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Peter Smith1
Reviewer
Bharath Rupireddy1
Julien Rouhaud1
Michael Paquiercommitter1
Tom Lane1
Committer
Michael Paquier1