update/delete and execution-time partition pruning

Started by Amit Langoteover 4 years ago4 messages

amitlangote09@gmail.com

over 4 years ago

1 attachment(s)

We apparently forgot in 86dc90056df to remove a note in 5.11.4.
Partition Pruning saying this:

<note>
<para>
Execution-time partition pruning currently only occurs for the
<literal>Append</literal> and <literal>MergeAppend</literal> node types.
It is not yet implemented for the <literal>ModifyTable</literal> node
type, but that is likely to be changed in a future release of
<productname>PostgreSQL</productname>.
</para>
</note>

Now because we include the Append/MergeAppend node even if the query
is update/delete, this note is no longer useful or valid.

Attached patch removes that note.

--
Amit Langote
EDB: http://www.enterprisedb.com

Attachments:

update-delete-exec-pruning-doc.patchapplication/octet-stream; name=update-delete-exec-pruning-doc.patchDownload

diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index 63bc946c3b..498654876f 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -4678,16 +4678,6 @@ EXPLAIN SELECT count(*) FROM measurement WHERE logdate &gt;= DATE '2008-01-01';
     Partition pruning can be disabled using the
     <xref linkend="guc-enable-partition-pruning"/> setting.
    </para>
-
-   <note>
-    <para>
-     Execution-time partition pruning currently only occurs for the
-     <literal>Append</literal> and <literal>MergeAppend</literal> node types.
-     It is not yet implemented for the <literal>ModifyTable</literal> node
-     type, but that is likely to be changed in a future release of
-     <productname>PostgreSQL</productname>.
-    </para>
-   </note>
   </sect2>
 
   <sect2 id="ddl-partitioning-constraint-exclusion">

David Rowley

dgrowleyml@gmail.com

over 4 years ago

In reply to: Amit Langote (#1)

Re: update/delete and execution-time partition pruning

On Tue, 11 May 2021 at 15:36, Amit Langote <amitlangote09@gmail.com> wrote:

We apparently forgot in 86dc90056df to remove a note in 5.11.4.
Partition Pruning saying this:

<note>
<para>
Execution-time partition pruning currently only occurs for the
<literal>Append</literal> and <literal>MergeAppend</literal> node types.
It is not yet implemented for the <literal>ModifyTable</literal> node
type, but that is likely to be changed in a future release of
<productname>PostgreSQL</productname>.
</para>
</note>

Now because we include the Append/MergeAppend node even if the query
is update/delete, this note is no longer useful or valid.

Attached patch removes that note.

Yeah. Agreed. That's out of date now.

I'll take care of this.

David

David Rowley

dgrowleyml@gmail.com

over 4 years ago

In reply to: David Rowley (#2)

Re: update/delete and execution-time partition pruning

On Tue, 11 May 2021 at 15:46, David Rowley <dgrowleyml@gmail.com> wrote:

I'll take care of this.

Pushed.

David

Amit Langote

amitlangote09@gmail.com

over 4 years ago

In reply to: David Rowley (#3)

Re: update/delete and execution-time partition pruning

On Tue, May 11, 2021 at 12:57 PM David Rowley <dgrowleyml@gmail.com> wrote:

On Tue, 11 May 2021 at 15:46, David Rowley <dgrowleyml@gmail.com> wrote:

I'll take care of this.

Pushed.

Thank you.

--
Amit Langote
EDB: http://www.enterprisedb.com