Apr 2022

1 commit
Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.
23 Apr 2022Noah Mischmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #5721 of 1 reviewer saw the final version

The five-file regression-test diff exactly matches #572, checking the preceding column's end offset and removing the typbyval dependency.

  • Masahiko Sawadasaw the final versionLLM analysis, 100% sureQuestioned conservative false positives in #573, accepted the explanation in #575, and is explicitly credited in the commit message.

Apr 2022

1 commit
Reorder subskiplsn in pg_subscription to avoid alignment issues.
7 Apr 2022Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #5662 of 2 reviewers saw the final version

Matches the catalog reorder and alignment test in #566, adding a catversion.h bump and PARALLEL SAFE to the test helper declarations.

  • Noah Mischsaw the final versiontrailerRan the diagnostics, diagnosed the tuple/C alignment mismatch in #547, and reviewed the fix through #565, after which only light changes followed.
  • Amit Kapilasaw the final versiontrailerReviewed alignment and comments in #553, approved the final patch in #567, and committed it with test-helper polish.

Mar 2022

1 commit
Add ALTER SUBSCRIPTION ... SKIP.
22 Mar 2022Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #5364 of 9 reviewers saw the final version

The implementation, documentation, and tests match Amit's forwarded #536; the additional change is the catalog-version bump. The patch header credits Masahiko Sawada.

  • Takamichi Osumisaw the final versiontrailerReviewed syntax, documentation, and origin-position handling across revisions and approved the near-final patch in #532.
  • Hou Zhijiesaw an earlier versiontrailerReviewed XID reset and accidental-target behavior in #64 and RESET prerequisites later, before the LSN redesign.
  • Peter Eisentrautsaw an earlier versiontrailerChallenged syntax and XID wraparound safety, supplied the fixup in #439, and defended a higher-level SKIP interface in #502 before subsequent implementation changes.
  • Amit Kapilasaw the final versiontrailerDrove syntax and correctness review, supplied the final revisions in #528 and #536, and committed the feature.
  • Shi Yusaw the final versiontrailerReported a streaming assertion failure in #510 and reviewed the corrected implementation in #526, followed only by light changes.
  • Vignesh Csaw an earlier versiontrailerFound concurrent target-clearing concerns in #361 and reviewed display and tests through #435, before the LSN redesign.
  • Greg Nancarrowsaw an earlier versiontrailerReviewed skipping risks, syntax, documentation, and tests, approving the XID-based version in #449 before its substantial redesign.
  • Haiying Tangsaw an earlier versiontrailerReviewed documentation and found the zero-valued completion-log bug in #466, before XID targeting changed to LSN targeting.
  • Euler Taveirasaw the final versiontrailerProvided final error-message and test comments in #534 and approved their incorporation in #537.

Jan 2022

1 commit
Update docs of logical replication for commit 8d74fc96db.
11 Jan 2022Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #3951 of 1 reviewer saw the final version

The logical-replication.sgml correction exactly matches #395, documenting that conflict details are available in pg_stat_subscription_workers as well as server logs.

  • Amit Kapilasaw the final versiontrailerIdentified the documentation omission while reviewing the broader patch in #392 and confirmed committing the extracted correction in #400.

Nov - Dec 2021

2 commits
Fix regression test failure caused by commit 8d74fc96db.
1 Dec 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: pgsql: Add a view to show the stats of subscription workers. (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3353 of 3 reviewers saw the final version

The commit matches the single-query polling fix in src/test/subscription/t/026_worker_stats.pl from #335, additionally removing redundant streaming = off configuration. This disagrees with attribution to thread #225823: its source #1099482 predates both local revisions, and #326 explicitly moved the fix discussion here.

  • Hou Zhijiesaw the final versiontrailerIdentified the remaining two-query race in #330 and approved the revised fix in #336.
  • Vignesh Csaw the final versiontrailerReported check-world and repeated test results in #329, with only test refinements following.
  • Amit Kapilasaw the final versiontrailerReviewed the polling race in #331 and #334 and confirmed committing the corrected test in #337.
Add a view to show the stats of subscription workers.
30 Nov 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3242 of 7 reviewers saw the final version

Matches the statistics-view implementation and TAP test in Amit's forwarded #324, with an additional catversion.h bump; other apparent differences are hunk boundaries. Its header identifies Masahiko Sawada as author.

  • Greg Nancarrowsaw an earlier versiontrailerReviewed statistics APIs, initialization, timestamps, and wording through approval in #314, before the purge-array logic changed in #321.
  • Hou Zhijiesaw an earlier versiontrailerReviewed hash iteration and tests and approved the patch in #318, before the later purge-array logic change.
  • Tang Haiyingsaw an earlier versiontrailerFound hidden retained tablesync rows in #292 and approved the revision in #320, before the final purge-array logic change.
  • Vignesh Csaw the final versiontrailerFound NULL-subscription and long-message failures and explicitly approved the final attached version in #325.
  • Dilip Kumarsaw an earlier versiontrailerReviewed view semantics, timestamps, and reset behavior in #267, before later statistics and cleanup changes.
  • Takamichi Osumisaw an earlier versiontrailerReviewed comments and error-source handling in #203, before the per-database storage redesign.
  • Amit Kapilasaw the final versiontrailerRequested database-local storage and supplied the final cleanup and test revisions in #321 and #324 before committing.

Aug 2021

3 commits
Add logical change details to logical replication worker errcontext.
27 Aug 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #1464 of 4 reviewers saw the final version

The proto.c, worker.c, logicalproto.h, and typedef-list changes match #146 modulo diff-hunk boundaries. Amit forwarded and polished Masahiko's error-context patch from #136.

  • Hou Zhijiesaw the final versiontrailerReviewed callback placement and later revisions, approving the near-final patch in #142 before light final polish.
  • Greg Nancarrowsaw the final versiontrailerReviewed error-context wording and behavior and approved the near-final version in #141.
  • Haiying Tangsaw the final versiontrailerReported missing nonstreamed context in #109, tested the correction, and approved the near-final version in #137.
  • Amit Kapilasaw the final versiontrailerDrove callback consolidation and supplied the final unset-timestamp and cosmetic adjustments in #146 before committing.
Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.
19 Aug 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1122 of 2 reviewers saw the final version

Extracts the three code-renaming hunks from #112; its protocol.sgml correction was committed separately as 0ac1aee0d7.

  • Hou Zhijiesaw the final versiontrailerExplicitly approved the combined rename and documentation patch in #116.
  • Amit Kapilasaw the final versiontrailerProposed separating the backpatchable documentation correction in #113 and confirmed committing both parts in #120.
Fix typo in protocol.sgml.
19 Aug 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14rc1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1122 of 2 reviewers saw the final version

Exactly extracts the protocol.sgml Stream End-to-Stream Stop correction from #112, leaving its enum rename for a separate commit.

  • Zhijie Hou (Fujitsu)saw the final versionLLM analysis, 99% sureApproved the combined patch containing this documentation correction in #116, before it was split for backpatching.
  • Amit Kapilasaw the final versioncommittercommitted the patch

Jul 2021

1 commit
Remove unused argument in apply_handle_commit_internal().
30 Jul 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3
LLM analysis, 96% surepart of a posted patchsetlight changesfrom patchset #621 of 1 reviewer saw the final version

Extracts the unused apply_handle_commit_internal argument removal present in #62. A standalone extraction is announced in #69 but is absent from the indexed patch files; its push is confirmed in #72.

  • Amit Kapilasaw the final versiontrailerReviewed and committed the extracted helper cleanup, confirming the push in #72.

Credits across 10 commits

Author
Masahiko Sawada9
Noah MischLLM1
Reviewer
Amit Kapilacommitter9
Hou, Zhijie5
Greg Nancarrow3
tanghy.fnst@fujitsu.com3
vignesh C3
osumi.takamichi@fujitsu.com2
Dilip Kumar1
Euler Taveira1
Noah Misch1
Peter Eisentraut1
Shi Yu1
Tested by
tanghy.fnst@fujitsu.com1
Reported by
Noah Misch1
Committer
Amit Kapila9
Noah Misch1

N LLM means N of the credits come from LLM analysis, not from commit trailers.