Jul 2021

2 commits
Don't use #if inside function-like macro arguments.
19 Jul 2021Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit implements Tom Lane's inline suggestion to move conditional O_CLOEXEC and O_DSYNC checks into separate StaticAssertStmt calls in src/backend/storage/file/fd.c #12. No attached patchset contains this fix; Thomas Munro confirms it was done in #13.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIdentified the portability risk of preprocessor directives inside macro arguments and supplied the separate-assertion pattern adopted by the commit #12.
Support direct I/O on macOS.
18 Jul 2021Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

The commit preserves the implementation across all four files from #4, including the synthetic flag, F_NOCACHE handling, and pg_test_fsync changes. Differences are a rewritten explanatory comment in src/include/storage/fd.h, whitespace, and commit-message wording.

  • Andres Freundsaw the final versiontrailerFlagged the initial API's failure to preserve direct-I/O state across virtual-file reopenings #3, then judged a complete internal flag mapping excessive compared with the revised approach #7.

Credits across 2 commits

Author
Thomas MunroLLM1
Reviewer
Andres Freund1
Reported by
Tom Lane1
Committer
Thomas Munro2

N LLM means N of the credits come from LLM analysis, not from commit trailers.