Jun 2021

1 commit
Fix postgres_fdw failure with whole-row Vars of type RECORD.
5 Jun 2021Tom Lanemaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 99% suremodified before commitlight changesfrom patchset #83 of 3 reviewers saw the final version

The commit retains the helper and both call-site changes from #8; the sole C-code difference is the defensive varattno check suggested in #12 and accepted as cheap insurance in #13. The regression test is adapted to existing ft2 fixtures instead of creating separate tables.

  • Andrei Lepikhovsaw the final versionLLM analysis, 98% sureIn #9, he reported exercising #8 without finding errors and questioned its handling of pushed-down ROW expressions.
  • Amit Langotesaw the final versionLLM analysis, 100% sureIn #12, he examined the tuple-descriptor code in #8 and proposed the whole-row varattno check included in the commit.
  • Alexander Pyhalovsaw the final versionLLM analysis, 98% sureBeyond reporting the original bug, he confirmed in #11 that #8 fixed the reported case and identified a related concern involving record-returning function pushdown.

Credits across 1 commit

Author
Tom LaneLLM1
Committer
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.