model-writtenrun 7405 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Zhijie Hou proposed replacing unnecessary formatted append calls across six files so the code would provide better examples for developers, while expecting little noticeable performance improvement #1.
- Michael Paquier supported proceeding #2, while Alvaro Herrera questioned the absence of compiler warnings #3; Peter Eisentraut explained that the existing formatted calls were valid, analogous to using printf where puts would suffice #4.
- David Rowley proposed limiting the changes to code introduced in PostgreSQL 14 to preserve consistency across future branches, excluding the older sepgsql and postmaster cases #5; Tom Lane supported avoiding unnecessary backpatch conflicts #6.
- David Rowley posted a revision that also replaced BRIN output-function calls with OutputFunctionCall, but explicitly separated that additional cleanup from the append-function changes #9.
- David Rowley committed the append-function subset of #9 as f736e188ce, retaining Hou's authorship, and confirmed the push in #11.
- David Rowley expanded the deferred BRIN cleanup into DatumGetCString conversions, strlen reuse, and numerous comment and copyright corrections, asking Tomas to check the comment changes #12.
- Peter Eisentraut explained that DatumGetPointer returns Pointer, which is already char *, accounting for the lack of warnings #13; David Rowley subsequently committed the code-only subset of #12 as 8bdb36aab2, leaving its comment and copyright edits out.
- After confirming the BRIN push, David Rowley proposed a separate OutputFunctionCall cleanup in older mcv.c code #14; Tom Lane advised against pursuing that cosmetic change #15, leaving the two core cleanups landed and no landing shown for the additional mcv.c or comment changes.