Documentation missing for PGSSLCRLDIR

Started by Michael Paquierover 4 years ago5 messages
#1Michael Paquier
michael@paquier.xyz
1 attachment(s)

Hi all,

I have noticed that the documentation for PGSSLCRLDIR is missing.
That seems like an oversight in f5465fa.

Thoughts?
--
Michael

Attachments:

doc-sslcrldir.patchtext/x-diff; charset=us-asciiDownload
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 2fc638c376..e1fc7f1f2b 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -7836,6 +7836,16 @@ myEventProc(PGEventId evtId, void *evtInfo, void *passThrough)
      </para>
     </listitem>
 
+    <listitem>
+     <para>
+      <indexterm>
+       <primary><envar>PGSSLCRLDIR</envar></primary>
+      </indexterm>
+      <envar>PGSSLCRLDIR</envar> behaves the same as the <xref
+      linkend="libpq-connect-sslcrldir"/> connection parameter.
+     </para>
+    </listitem>
+
     <listitem>
      <para>
       <indexterm>
#2Kyotaro Horiguchi
horikyota.ntt@gmail.com
In reply to: Michael Paquier (#1)
Re: Documentation missing for PGSSLCRLDIR

At Thu, 3 Jun 2021 12:13:22 +0900, Michael Paquier <michael@paquier.xyz> wrote in

Hi all,

I have noticed that the documentation for PGSSLCRLDIR is missing.
That seems like an oversight in f5465fa.

Thoughts?

Ugg.. Thanks for finding that. I don't find a similar mistake in the
same page.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

#3Daniel Gustafsson
daniel@yesql.se
In reply to: Michael Paquier (#1)
1 attachment(s)
Re: Documentation missing for PGSSLCRLDIR

On 3 Jun 2021, at 05:13, Michael Paquier <michael@paquier.xyz> wrote:

I have noticed that the documentation for PGSSLCRLDIR is missing.
That seems like an oversight in f5465fa.

+1 on applying this.

While looking at this I found another nearby oversight which needs a backport
down to 13 where it was introduced. The PGSSLMAXPROTOCOLVERSION documentation
is linking to the minimum protocol version docs. Fixed in the attached.

--
Daniel Gustafsson https://vmware.com/

Attachments:

0001-Fix-linkend-reference-for-PGSSLMAXPROTOCOLVERSION.patchapplication/octet-stream; name=0001-Fix-linkend-reference-for-PGSSLMAXPROTOCOLVERSION.patch; x-unix-mode=0644Download
From 7ee8e5107508156b3abf66588c41f93255f2a227 Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <daniel@yesql.se>
Date: Thu, 3 Jun 2021 14:03:46 +0200
Subject: [PATCH] Fix linkend reference for PGSSLMAXPROTOCOLVERSION

It was erroneously pointing at the documentation for the minimum
protocol version.
---
 doc/src/sgml/libpq.sgml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 2fc638c376..11ab8c1c36 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -7872,7 +7872,7 @@ myEventProc(PGEventId evtId, void *evtInfo, void *passThrough)
        <primary><envar>PGSSLMAXPROTOCOLVERSION</envar></primary>
       </indexterm>
       <envar>PGSSLMAXPROTOCOLVERSION</envar> behaves the same as the <xref
-      linkend="libpq-connect-ssl-min-protocol-version"/> connection parameter.
+      linkend="libpq-connect-ssl-max-protocol-version"/> connection parameter.
      </para>
     </listitem>
 
-- 
2.30.1 (Apple Git-130)

#4Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#3)
Re: Documentation missing for PGSSLCRLDIR

On Thu, Jun 03, 2021 at 02:08:02PM +0200, Daniel Gustafsson wrote:

While looking at this I found another nearby oversight which needs a backport
down to 13 where it was introduced. The PGSSLMAXPROTOCOLVERSION documentation
is linking to the minimum protocol version docs. Fixed in the attached.

Thanks, fixed this bit.
--
Michael

#5Michael Paquier
michael@paquier.xyz
In reply to: Kyotaro Horiguchi (#2)
Re: Documentation missing for PGSSLCRLDIR

On Thu, Jun 03, 2021 at 01:42:20PM +0900, Kyotaro Horiguchi wrote:

Ugg.. Thanks for finding that. I don't find a similar mistake in the
same page.

Thanks for double-checking. Applied.
--
Michael