Aug 2022

1 commit
Fix MSVC build script's check for obsolete node support functions.
8 Aug 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #870 of 1 reviewer saw the final version

The stable patch ID exactly matches #87, including input-header timestamp checks, empty-element filtering, and expanded generator diagnostics.

  • Amit Kapilasaw an earlier versionLLM analysis, 99% sureReported the regeneration failure and tested #85, exposing the argument-list bug in #86; the final filtering fix followed, and his committed-version verification in #89 was after the commit.

Jul 2022

11 commits
Tighten up parsing logic in gen_node_support.pl.
14 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #81

Extends #81 with special handling for semicolon-free node-attribute lines and an explicit read_write_ignore annotation on IndexOptInfo.amcostestimate.

Add defenses against unexpected changes in the NodeTag enum list.
12 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #731 of 2 reviewers saw the final version

Includes the manual tag numbering and stable-branch checks from #73, plus a canonical input-file list and argument-order validation developed in #66 through #78.

  • Andres Freundsaw the final versionLLM analysis, 96% sureIdentified the cross-build-system ABI risk in #65 and accepted the canonical-list validation design in #78.
  • Robert Haassaw an earlier versionLLM analysis, 80% sureSupported retaining generated tags despite the ABI concern in #64 and challenged the proposed file-list duplication in #68, before the concrete validation implementation.
Add copy/equal support for XID lists
12 Jul 2022Alvaro Herreramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #490 of 1 reviewer saw the final version

Preserves the XidList copying fix from #49 and adds equality handling in equalfuncs.c plus the test_oat_hooks tag-name case.

  • Tom Lanesaw an earlier versionLLM analysis, 100% sureApproved the copying fix and asked about equalfuncs coverage in #50, prompting additional logic before commit.
Rationalize order of input files for gen_node_support.pl.
11 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

Implements the input-order discussion in #56 through #61, ordering principal headers by dependency and incidental headers alphabetically in both build systems; no matching attachment was posted.

  • Andres Freundsaw an earlier versionLLM analysis, 98% sureRequested a documented or systematic input-file order in #56, directly motivating the change before the thread's later build-system revisions.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 93% sureExplained the dependency constraints and supported trying the proposed ordering in #58, before subsequent ABI and MSVC changes.
Make assorted quality-of-life improvements in gen_node_support.pl.
9 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #55

Combines the three gen_node_support.pl patches from #55, leaving its README patch for a separate commit. Applying those three attachments reproduces the committed script exactly.

Doc: rearrange high-level commentary about node support coverage.
9 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #55

Expands the README attachment from #55 with plan-serialization coverage and relocates related commentary from outfuncs.c, readfuncs.c, and execnodes.h.

Automatically generate node support functions
9 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #511 of 1 reviewer saw the final version

Applying all four attachments in #51 reproduces the committed implementation except for the nodes.h comment correction supplied in #52 and a catalog-version bump. The principal patch is Peter's work forwarded with Tom's amendments.

  • Tom Lanesaw the final versiontrailerReviewed documentation, build rules, attributes, and generated behavior, supplied corrective deltas in #44 and #51, and provided the final comment correction in #52.
Adjust node serialization tag of A_Expr for consistency
8 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 98% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Changes the manual _outA_Expr label from AEXPR to A_EXPR in response to the underscore-consistency discussion in #44; that one-line manual-code patch was not attached.

  • Tom Lanesaw an earlier versionLLM analysis, 92% sureIdentified unnecessary underscore stripping and supplied the generator-side correction in #44, before later generator revisions.
Remove T_Join and T_Plan
8 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 95% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Implements the decision in #44 to make Plan and Join abstract by removing their existing tags and manual copy/out/read routines, with a catalog-version bump. The attachment expressed this through generator attributes rather than this standalone manual-code removal.

  • Tom Lanesaw an earlier versionLLM analysis, 94% sureIdentified Plan and Join as abstract and implemented that policy in his generator review at #44, before later revisions.
Reformat some more node comments
8 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 97% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

Adds a second formatting pass over PlannerGlobal, PlannerInfo, and ForeignKeyCacheInfo to accommodate additional attributes discussed in #40 and #42. These hunks are absent from the standalone formatting attachment in #37.

  • Tom Lanesaw an earlier versionLLM analysis, 94% sureReported remaining pgindent problems and requested more explicit header annotations in #40, before subsequent generator revisions.
  • David Rowleysaw an earlier versionLLM analysis, 85% sureProposed moving long field comments above declarations in #28, the formatting approach continued by this additional cleanup.
Reformat some node comments
2 Jul 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #372 of 2 reviewers saw the final version

Matches the comment-formatting patch in #37 with additional RangeVar and Var comment reformatting in primnodes.h; the changes remain cosmetic.

  • David Rowleysaw the final versionLLM analysis, 96% sureIdentified overlong annotated declarations and proposed the adopted comment-above-field layout in #28.
  • Tom Lanesaw the final versionLLM analysis, 95% sureRequested pgindent-safe restructuring of node-header comments in #21, which the standalone formatting patch implements.

May 2022

2 commits
Remove JsonPathSpec typedef
4 May 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

Removes JsonPathSpec in favor of char pointers following Alvaro's parser-failure report in #32 and the explicit agreement in #33 and #34; no removal patch was attached.

  • Alvaro Herrerasaw an earlier versionLLM analysis, 93% sureReported that JsonPathSpec's typedef pattern prevented the rebased generator from compiling in #32, motivating its removal before later generator revisions.
  • Tom Lanesaw an earlier versionLLM analysis, 99% sureQuestioned the typedef's usefulness and proposed replacing it with a String or char pointer in #33, which Peter accepted in #34.
Add missing enum tag in enum used in nodes
4 May 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #321 of 1 reviewer saw the final version

The stable patch ID exactly matches Alvaro's separate JsonTableColumnType enum-tag attachment in #32.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Sep 2021

5 commits
Add Cardinality typedef
15 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #91 of 1 reviewer saw the final version

Matches the Cardinality attachment in #9 with the additional RangeTblEntry.enrtuples typedef substitution requested in #10 and accepted in #11.

  • Jacob Championsaw the final versionLLM analysis, 100% sureReviewed the preparatory series and identified enrtuples as another Cardinality field in #10.
Make node output prefix match node structure name
15 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #92 of 2 reviewers saw the final version

The stable patch ID exactly matches the node-output-prefix attachment in #9, including corresponding readfuncs.c labels.

  • Jacob Championsaw the final versionLLM analysis, 100% sureReviewed the label changes and raised the increased serialization-length question in #10.
  • Noah Mischsaw the final versionLLM analysis, 99% sureAssessed the serialization-size concern and found the increase acceptable in #12.
Add WRITE_INDEX_ARRAY
14 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #91 of 1 reviewer saw the final version

The stable patch ID exactly matches the WRITE_INDEX_ARRAY attachment in #9.

  • Jacob Championsaw the final versiontrailerSaid the preparatory patches looked sane in #10; this attachment landed unchanged.
Add COPY_ARRAY_FIELD and COMPARE_ARRAY_FIELD
14 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #91 of 1 reviewer saw the final version

The stable patch ID exactly matches the COPY_ARRAY_FIELD and COMPARE_ARRAY_FIELD attachment in #9.

  • Jacob Championsaw the final versiontrailerReviewed the preparatory patches favorably in #10; the array-macro implementation landed unchanged.
Remove T_Expr
14 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #91 of 1 reviewer saw the final version

The stable patch ID exactly matches the T_Expr removal attachment in #9.

  • Jacob Championsaw the final versiontrailerReviewed the preparatory series favorably in #10, including this unchanged abstract-tag removal.

Aug 2021

4 commits
Change NestPath node to contain JoinPath node
8 Aug 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The stable patch ID exactly matches the NestPath embedding attachment in #1, including optimizer field-access updates.

  • Tom Lanesaw the final versionLLM analysis, 100% sureReviewed the initial preparatory changes without objections in #8, before the NestPath change landed.
Check the size in COPY_POINTER_FIELD
8 Aug 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The stable patch ID exactly matches the COPY_POINTER_FIELD size-check attachment in #1.

  • Tom Lanesaw the final versionLLM analysis, 100% sureReported reviewing the preparatory patches without objections in #8, before this unchanged patch landed.
Change SeqScan node to contain Scan node
8 Aug 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The stable patch ID exactly matches the SeqScan embedding attachment in #1, including executor and planner field-access changes.

  • Tom Lanesaw the final versionLLM analysis, 100% sureReported reviewing the first eight preparatory patches without objections in #8, before this commit.
Remove T_MemoryContext
7 Aug 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The stable patch ID exactly matches the T_MemoryContext removal attachment in #1.

  • Tom Lanesaw the final versionLLM analysis, 100% sureReviewed the first eight preparatory patches without objections in #8, before this tag removal landed.

Jul 2021

4 commits
Add missing enum tags in enums used in nodes
21 Jul 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #1

The stable patch ID exactly matches the missing-enum-tags attachment in #1; Tom's explicit review of these preparatory patches in #8 occurred after this commit.

Rename some node support functions for consistency
21 Jul 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #1

The stable patch ID exactly matches the support-function renaming attachment in #1, affecting copyfuncs.c, equalfuncs.c, and outfuncs.c.

Rename argument of _outValue()
21 Jul 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #1

The stable patch ID exactly matches the _outValue argument-renaming attachment in #1.

Rename NodeTag of ExprState
21 Jul 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #1

The stable patch ID exactly matches the ExprState tag-to-type field rename in #1, including both executor references.

Credits across 27 commits

Author
Peter EisentrautLLM15
Tom LaneLLM5
Alvaro Herrera1 LLM2
Reviewer
Jacob Champion3
Peter Eisentrautcommitter1
Tom Lane1
Committer
Peter Eisentraut20
Tom Lane6
Alvaro Herrera1

N LLM means N of the credits come from LLM analysis, not from commit trailers.