Remove unused code from the KnownAssignedTransactionIdes submodule
Hi,
In the KnownAssignedTransactionIdes sub-module, two lines of unused code
were found in a previous change.
--
Quan Zongliang
CPUG
Attachments:
procarray.patchtext/plain; charset=UTF-8; name=procarray.patch; x-mac-creator=0; x-mac-type=0Download
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index b448533564..99ce8c752a 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -3363,8 +3363,6 @@ RecordKnownAssignedTransactionIds(TransactionId xid)
/* ShmemVariableCache->nextFullXid must be beyond any observed xid */
AdvanceNextFullTransactionIdPastXid(latestObservedXid);
- next_expected_xid = latestObservedXid;
- TransactionIdAdvance(next_expected_xid);
}
}
On Tue, 2021-06-08 at 17:32 +0800, Quan Zongliang wrote:
Hi,
In the KnownAssignedTransactionIdes sub-module, two lines of unused code
were found in a previous change.
Huh. Looks like this code died as part of 2fc7af5e966?
CC'ing Thomas just in case we're missing something, but I'll mark this
Ready for Committer. Thanks!
--Jacob
On Fri, Jul 2, 2021 at 5:24 AM Jacob Champion <pchampion@vmware.com> wrote:
On Tue, 2021-06-08 at 17:32 +0800, Quan Zongliang wrote:
In the KnownAssignedTransactionIdes sub-module, two lines of unused code
were found in a previous change.Huh. Looks like this code died as part of 2fc7af5e966?
CC'ing Thomas just in case we're missing something, but I'll mark this
Ready for Committer. Thanks!
Thanks! Agreed. No change to generated code on my machine. Pushed.