model-writtenrun 7375 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Michael Paquier reported a subscription-test failure caused by dropping an active replication slot and suggested polling the slot’s state in the test #1.
- Amit Kapila identified a race between stopping the subscription worker and the publisher’s walsender exiting #2, while Tom Lane supplied two more buildfarm failures and argued that the recurring problem required a fix #3.
- Masahiko Sawada observed that DROP SUBSCRIPTION already requests WAIT and traced the failure to an inverted nowait condition, attaching a one-line correction in src/backend/replication/slot.c #4.
- Amit Kapila confirmed that the correction should address the recent failures #5, and Alvaro Herrera agreed to handle it #6.
- Alvaro Herrera committed the fix from #4 as 33c5099567, restructuring the wait/error branches to keep the !nowait tests consistent and correcting outdated comments.
- With the fix landed, Alvaro Herrera questioned whether the infrequent failures reflected insufficient test coverage and whether the same bug explained failures in a test he had previously tried to add; those testing questions remained open at the thread’s end #7.