Jun 2021

2 commits
Avoid scribbling on input node tree in CREATE/ALTER DOMAIN.
18 Jun 2021Tom LaneREL_13_STABLE13.4REL_12_STABLE12.8REL_11_STABLE11.13REL_10_STABLE10.18REL9_6_STABLE9.6.23Also in: BUG #17053: Memory corruption in parser on prepared query reuse (landed as posted)
Centralize the logic for protective copying of utility statements.
18 Jun 2021Tom Lanemaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2Also in: BUG #17053: Memory corruption in parser on prepared query reuse (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #43 of 3 reviewers saw the final version

The committed diff matches #4 except for comments in src/backend/executor/spi.c, src/backend/tcop/pquery.c, and src/backend/tcop/utility.c, including clarification of readOnlyTree. Tom confirmed pushing it with comment tweaks in #18.

  • Julien Rouhaudsaw the final versionLLM analysis, 100% sureJulien supported the explicit API change and questioned the readOnlyTree wording #5, then approved the clarification before the commit #17.
  • Andres Freundsaw the final versionLLM analysis, 94% sureAndres questioned transaction-statement copying costs #6 and the revised API's extension compatibility impact during beta #7, prompting benchmarking and compatibility discussion.
  • Michael Paquiersaw the final versionLLM analysis, 96% sureMichael supported fixing the API during beta and asked why ExplainOneUtility still copied DECLARE CURSOR queries #14, which Tom explained through the existing EXPLAIN EXECUTE comment #15.

Credits across 2 commits

Author
Tom LaneLLM2
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.