model-writtenrun 6401 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane proposed replacing pgbench's reconstructed version number with PG_VERSION and reporting a differing server version, borrowing psql's banner logic and printing while the initial connection remained available #1.
- Fabien COELHO tested the patch successfully and suggested printing immediately after connecting #2; Tom agreed but explained that this required changing a test that expected empty stdout before an initialization error #3.
- Tom committed 84bee96109 from #1, moving the banner as suggested and dropping the affected test's empty-stdout assertion.
- After the commit, Fabien posted two alternatives that moved the banner and explicitly tested its output, with the second additionally printing the local version when connection establishment failed #4.
- Tom argued that omitting the banner on connection failure matched psql and its purpose of reporting the server version #5; Fabien accepted that behavior, leaving the committed improvement in place without the additional failure-path banner #6.