genbki stricter error handling

Started by Peter Eisentrautalmost 5 years ago2 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

genbki.pl says:

# Perform OID lookups on an array of OID names.
# If we don't have a unique value to substitute, warn and
# leave the entry unchanged.
# (A warning seems sufficient because the bootstrap backend will reject
# non-numeric values anyway. So we might as well detect multiple problems
# within this genbki.pl run.)

This is fine, but I have found this to be a bit cumbersome in practice
sometimes, because errors are then not easily seen at build time but
have to be extracted from some log files during test runs.

I propose the attached patch to make genbki.pl error out if it
encounters any errors in this routine, while preserving the property
that all errors in one run are reported.

Attachments:

0001-genbki-stricter-error-handling.patchtext/plain; charset=UTF-8; name=0001-genbki-stricter-error-handling.patch; x-mac-creator=0; x-mac-type=0Download+12-8
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: genbki stricter error handling

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

I propose the attached patch to make genbki.pl error out if it
encounters any errors in this routine, while preserving the property
that all errors in one run are reported.

+1, looks sane in a quick read-through.

regards, tom lane