Weird use of parentheses in the manual

Started by Guillaume Lelargeover 4 years ago4 messages
#1Guillaume Lelarge
guillaume@lelarge.info
1 attachment(s)

Hey,

I was translating logicaldecoding.sgml, and I saw this sentence:

There are multiple required streaming callbacks
(<function>stream_start_cb</function>, <function>stream_stop_cb</function>,
<function>stream_abort_cb</function>, <function>stream_commit_cb</function>
and <function>stream_change_cb</function>) and two optional callbacks
(<function>stream_message_cb</function>) and
(<function>stream_truncate_cb</function>).

The two last sets of parentheses seem really weird to me. Looks like it
should be:
(<function>stream_message_cb</function> and
<function>stream_truncate_cb</function>).

Really tiny patch attached to fix this if it really is wrong, and anyone
cares enough to fix it :)

Regards.

--
Guillaume.

Attachments:

logicaldecoding.patchtext/x-patch; charset=US-ASCII; name=logicaldecoding.patchDownload
diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index 1765ea6c87..f2d3f1c6a8 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -1173,7 +1173,7 @@ OutputPluginWrite(ctx, true);
     (<function>stream_start_cb</function>, <function>stream_stop_cb</function>,
     <function>stream_abort_cb</function>, <function>stream_commit_cb</function>
     and <function>stream_change_cb</function>) and two optional callbacks
-    (<function>stream_message_cb</function>) and (<function>stream_truncate_cb</function>).
+    (<function>stream_message_cb</function> and <function>stream_truncate_cb</function>).
    </para>
 
    <para>
#2Amit Kapila
amit.kapila16@gmail.com
In reply to: Guillaume Lelarge (#1)
Re: Weird use of parentheses in the manual

On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge
<guillaume@lelarge.info> wrote:

Really tiny patch attached to fix this if it really is wrong, and anyone cares enough to fix it :)

LGTM. I'll take care of this tomorrow unless someone else has any
suggestions in this regard.

--
With Regards,
Amit Kapila.

#3Amit Kapila
amit.kapila16@gmail.com
In reply to: Amit Kapila (#2)
Re: Weird use of parentheses in the manual

On Thu, Jun 24, 2021 at 6:38 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge
<guillaume@lelarge.info> wrote:

Really tiny patch attached to fix this if it really is wrong, and anyone cares enough to fix it :)

LGTM. I'll take care of this tomorrow unless someone else has any
suggestions in this regard.

Pushed.

--
With Regards,
Amit Kapila.

#4Guillaume Lelarge
guillaume@lelarge.info
In reply to: Amit Kapila (#3)
Re: Weird use of parentheses in the manual

Le ven. 25 juin 2021 à 08:55, Amit Kapila <amit.kapila16@gmail.com> a
écrit :

On Thu, Jun 24, 2021 at 6:38 PM Amit Kapila <amit.kapila16@gmail.com>
wrote:

On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge
<guillaume@lelarge.info> wrote:

Really tiny patch attached to fix this if it really is wrong, and

anyone cares enough to fix it :)

LGTM. I'll take care of this tomorrow unless someone else has any
suggestions in this regard.

Pushed.

Thanks.

--
Guillaume.