Jun - Jul 2021

4 commits
Further restrict the scope of no-exit()-in-libpq test.
3 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

Adds Makefile guards disabling the check for coverage builds, AIX and Solaris; no attachment contains these guards. The change follows Jacob's coverage failure #42, Noah's static-libldap diagnosis #49, and Tom's proposed platform restriction #51.

  • Alvaro Herrerasaw the final versionLLM analysis, 94% sureReported the installed check rejecting atexit and pthread_exit on hoverfly in #40, initiating the static-library investigation that led to platform exclusions.
  • Jacob Championsaw the final versionLLM analysis, 99% sureReported and investigated the remaining --enable-coverage failure in #42, #44 and #46, prompting the coverage exclusion.
  • Noah Mischsaw the final versionLLM analysis, 99% sureTraced hoverfly's rejected symbols to statically linked libldap_r in #49, providing the diagnosis behind the platform exclusions.
Improve build-time check that libpq doesn't call exit().
1 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #232 of 3 reviewers saw the final version

Preserves all stamp-file, cleanup and .gitignore changes from #23. The only additional code edit removes nm's redundant -g option after Noah demonstrated its conflict with -u on Solaris in #30.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 97% sureMeasured repeated executions of the original check and requested running it only when the library changes in #21, prompting the subsequent stamp-file implementation.
  • Jacob Championsaw the final versionLLM analysis, 99% sureDiscussed an alternative placement in #24 and explicitly endorsed the stamp-file approach in #26 after considering preservation of debugging evidence.
  • Noah Mischsaw the final versionLLM analysis, 98% sureDemonstrated the Solaris nm option conflict in #30 and explained the POSIX syntax in #32, leading directly to removal of -g.
Fix portability fallout from commit dc227eb82.
30 Jun 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Drops the abort() check and its _eprintf.o exception, and filters __cxa_atexit in src/interfaces/libpq/Makefile, implementing the discussion in #7 and #15. Neither change proposed by the attached coverage experiment #14 was adopted.

  • Alvaro Herrerasaw an earlier versionLLM analysis, 91% sureInvestigated coverage failures, successfully tested removing the abort check in #16, and requested removing its obsolete exception in #18, before the later stamp-file patch #23.
Add a build-time check that libpq doesn't call exit() or abort().
29 Jun 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

Retains the Makefile target and nm pipeline from #1, but adds a _eprintf.o exclusion for ancient macOS assertion support, expands the comment, and removes command echo suppression. The added filtering case is explained in #6.

  • Michael Paquiersaw an earlier versionLLM analysis, 93% sureConfirmed cfbot detected the intended abort references and questioned broad symbol matching in #2, before the macOS filtering exception was added.

Credits across 4 commits

Author
Tom LaneLLM2
Committer
Tom Lane4

N LLM means N of the credits come from LLM analysis, not from commit trailers.