model-writtenrun 6360 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane proposed checking libpq's completed shared library with nm to prevent accidental abort() and exit() calls, including calls imported from src/common or src/port, while allowing unsupported nm implementations to skip the check silently #1.
- Michael Paquier questioned broad symbol matching and Fabien COELHO suggested preprocessor renaming, but Tom retained the shared-library check because symbol formats vary and preprocessor definitions would not reliably catch indirect calls through imported code #2 #3 #4 #5.
- Tom discovered that ancient macOS assertion support legitimately introduces an abort reference, added an _eprintf.o exclusion, and committed the modified initial patch as dc227eb82e #6 #7.
- The first landing exposed OpenBSD's injected __cxa_atexit reference, an unexplained abort reference with icc, and coverage-build failures investigated by Alvaro Herrera #7 #8 #9 #12.
- Alvaro attached an experiment removing -fprofile-arcs from shared-library linking and excluding __gcov_exit, but reported that applications then failed to link against libpq, so this attachment was abandoned #14.
- Tom proposed dropping the abort prohibition because toolchains introduce legitimate abort calls, and Alvaro confirmed that this fixed his coverage build; e45b0dfa1f implemented that discussion, removed the obsolete macOS exception, and excluded OpenBSD's __cxa_atexit #15 #16 #18 #19.
- Peter Eisentraut reported that the phony target ran dozens of times during normal build workflows, prompting Tom's stamp-file patch; Jacob Champion endorsed that approach after Tom explained that integrating the check into the link rule could delete the library needed to investigate failures #21 #23 #24 #25 #26.
- Noah Misch diagnosed a Solaris false positive: unsupported grep options had previously hidden the problem, and nm ignored -u when combined with -g; 2f7bae2f92 landed the stamp-file patch with -g removed #27 #30 #32 #33.
- Alvaro's suggestion to use configured $(GREP) was left out because the revised command no longer required it, and Tom retained the separate stamp rule when discussion of placing the check inside the link recipe continued #28 #34 #38 #39.
- A further failure round began when Alvaro reported atexit and pthread_exit references on hoverfly and Jacob reported that Ubuntu coverage builds still introduced exit references; Noah traced hoverfly's symbols to statically linked libldap_r #40 #42 #46 #49.
- Tom considered checking object files and support archives instead, but rejected that approach because removing prohibited routines from an archive could let unintended references resolve against application symbols and escape testing #50 #51.
- After reproducing the coverage failure with newer GCC, Tom committed 792259591c, disabling the check for coverage builds and for AIX and Solaris, where statically linked dependencies could violate libpq's restrictions #51 #52.
- Noah subsequently questioned the platform exclusions and suggested an environment switch or detecting statically linked dependencies, while Tom preferred automatic checking and waiting for concrete complaints before restricting it further #53 #54 #55 #56.
- The thread ended with all four commits retained and Alvaro's experimental attachment unmerged; static dependencies on other platforms remained a potential limitation, and MSVC still lacked an equivalent check, with Noah considering non-MSVC Windows coverage sufficient #56 #57.