Add '--ignore-errors' into pg_regress

Started by Andrei Lepikhovabout 5 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t44469
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 04:43 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t44469_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t44469_1 && git checkout t44469_1

Patchset v1 (message #1) is on t44469_1

Jump to latest
#1Andrei Lepikhov
lepihov@gmail.com

Hi,

I want to add the '--ignore-errors' option into the pg_regress module.

I understand it can't be used in the regression or TAP tests. But such
option is useful to test a custom extension. A custom extension couldn't
pass all check-world tests and will be stopped at the end of first stage.
My use case of this feature is to run check-world, look for core files
and analyze diffs of failed (but ignored) tests. Maybe it is not
difficult to apply this patch before the test in CI script, but annoying
procedure.
I think this patch could be applied because it is trivial and can be
easy reverted if needed.

An example:
TEMP_CONFIG=/tmp/extra.config \
EXTRA_REGRESS_OPTS="--load-extension=aqo --ignore-errors
--schedule=src/test/regress/parallel_schedule" \
make check-world

Maybe I just don't know the right way?

--
regards,
Andrey Lepikhov
Postgres Professional

Attachments:

t44469_1
0001-Add-a-ignore-all-errors-option-into-pg_regress.patchtext/plain; charset=UTF-8; name=0001-Add-a-ignore-all-errors-option-into-pg_regress.patch; x-mac-creator=0; x-mac-type=0Download+25-7
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrei Lepikhov (#1)
Re: Add '--ignore-errors' into pg_regress

Andrey Lepikhov <a.lepikhov@postgrespro.ru> writes:

I want to add the '--ignore-errors' option into the pg_regress module.

I understand it can't be used in the regression or TAP tests. But such
option is useful to test a custom extension.

I'm really skeptical that this has any positive use. It seems more
likely to be a foot-gun.

Also, pg_regress will already complete all the tests in a particular
suite, and I'm not clear on why you wouldn't try to get (say) the core
suite passing before trying something else. If the core suite has got
problems it seems unlikely that you can learn much from other suites.

BTW, I wonder if you can't get much or all of the same effect
from "make -k check-world".

regards, tom lane

#3Andrei Lepikhov
lepihov@gmail.com
In reply to: Tom Lane (#2)
Re: Add '--ignore-errors' into pg_regress

On 29/6/21 20:59, Tom Lane wrote:

Andrey Lepikhov <a.lepikhov@postgrespro.ru> writes:
BTW, I wonder if you can't get much or all of the same effect
from "make -k check-world".

Thank you, 'make -k' is suitable solution in such situation.

--
regards,
Andrey Lepikhov
Postgres Professional