Jul 2021

1 commit
Rename debug_invalidate_system_caches_always to debug_discard_caches.
13 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3
LLM analysis, 100% surelanded as postedfrom patchset #187 of 7 reviewers saw the final version

All 43 hunks across 19 files in d68a003912 match #18 exactly after excluding diff index lines. The changes include debug_discard_caches in src/backend/utils/misc/guc.c, --discard-caches in src/bin/initdb/initdb.c, and DISCARD_CACHES_ENABLED in src/include/pg_config_manual.h.

  • Noah Mischsaw the final versionLLM analysis, 96% sureNoah explained why “always” and “clobber” were misleading in #2 and approved the final naming proposal in #17, before the attachment.
  • Justin Pryzbysaw the final versionLLM analysis, 80% sureJustin endorsed removing “always” in #3, a naming change retained in the final patch, before the attachment.
  • Bharath Rupireddysaw the final versionLLM analysis, 83% sureBharath questioned whether “flush” misleadingly implied writing to disk in #9, prompting the discussion that selected “discard” before the attachment.
  • Andrew Dunstansaw the final versionLLM analysis, 99% sureAndrew proposed “discard” in #10, which became the committed GUC and initdb option names.
  • Peter Eisentrautsaw the final versionLLM analysis, 94% surePeter supported dropping “always” and explained that actual clobbering requires CLOBBER_FREED_MEMORY in #12, supporting the adopted terminology before the attachment.
  • Robert Haassaw the final versionLLM analysis, 98% sureRobert favored debug_discard_caches as the clearest name in #14, which Tom accepted before posting the attachment.
  • Alvaro Herrerasaw the final versionLLM analysis, 92% sureAlvaro approved the agreed naming proposal in #16, before the attachment.

Credits across 1 commit

Author
Tom LaneLLM1
Committer
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.