Apr 2024

1 commit
radixtree: Fix SIGSEGV at update of embeddable value to non-embeddable.
25 Apr 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #4592 of 2 reviewers saw the final version

The radixtree.h fix and overwrite tests match #459; the patch and commit credit Noah Misch, whose original submission is #455.

  • Masahiko Sawadasaw the final versiontrailerReviewed Noah's fix and expanded its tests in #457, then committed the final version.
  • John Naylorsaw the final versiontrailerTested the expanded cases and requested removal of obsolete warnings in #458, followed only by light changes.

Mar - Apr 2024

19 commits
Get rid of anonymous struct
9 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #4501 of 1 reviewer saw the final version

Implements the anonymous-struct and union removal in #450, with rewritten pointer-tagging comments and an additional padding comment in tidstore.c.

  • Pavel Borisovsaw the final versionLLM analysis, 100% sureReported the C99 incompatibility and reviewed the proposed union removal and offset-capacity calculation in #451, also receiving explicit commit credit.
Teach radix tree to embed values at runtime
8 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #4460 of 1 reviewer saw the final version

Takes the runtime-embedding component of #446, carried from #445, and additionally computes NUM_FULL_OFFSETS from uintptr_t and the actual header fields.

  • Masahiko Sawadasaw an earlier versionLLM analysis, 99% sureBenchmarked and reviewed an earlier archive-only embedding version in #347; the commit explicitly credits this earlier review.
Teach TID store to skip bitmap for small numbers of offsets
8 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #4460 of 1 reviewer saw the final version

Combines the small-offset header-storage and formatting components of #446, leaving runtime embedding, bump allocation, and development instrumentation for other changes.

  • Masahiko Sawadasaw an earlier versionLLM analysis, 98% sureTested the earlier archive-only small-offset design in #347 and discussed header limits in #416, as acknowledged by the commit's earlier-review credit.
Use bump context for TID bitmaps stored by vacuum
8 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #4460 of 1 reviewer saw the final version

Takes the bump-context integration component of #446; the only substantive textual difference within that component is the iteration-context name.

  • Masahiko Sawadasaw an earlier versionLLM analysis, 90% sureProposed the adopted TidStore-owned context, caller flag, and separately freeable iterator design in #349, before an indexed implementation was available.
Fix alignment of stack variable
8 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #4471 of 1 reviewer saw the final version

The alignment union and buffer cast in tidstore.c exactly match Andres's #447 apart from indentation.

  • John Naylorsaw the final versioncommittercommitted the patch
Use TidStore for dead tuple TIDs storage during lazy vacuum.
2 Apr 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #4441 of 2 reviewers saw the final version

Matches the final vacuum integration in #444, with the additional catalog-version bump required by the progress-view changes.

  • John Naylorsaw the final versiontrailerReviewed the integration and tested billion-row parallel vacuum in #441, then supplied final documentation and commit-message edits in #443.
  • Dilip Kumarsaw an earlier versiontrailerReviewed vacuum memory settings, stale array comments, and naming in #185, before substantial storage and API changes.
Rethink create and attach APIs of shared TidStore.
28 Mar 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #4391 of 1 reviewer saw the final version

Takes the shared-TidStore API component of #439, with a prototype parameter renamed to area_handle and minor comment wrapping.

  • John Naylorsaw the final versiontrailerReviewed DSA ownership, constructor separation, and sizing, then approved the approach with cosmetic edits in #438.
Fix inconsistent function prototypes with function definitions.
26 Mar 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #4371 of 1 reviewer saw the final version

Uses the prototype-consistency fix carried in #437, expanding the parameter-name cleanup to both TidStoreCreate and TidStoreAttach in src/include/access/tidstore.h.

  • John Naylorsaw the final versiontrailerExplicitly accepted the calculation and prototype fixes in #436, with only parameter-name cleanup following.
Fix a calculation in TidStoreCreate().
26 Mar 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #4291 of 1 reviewer saw the final version

Exactly takes the calculation-fix component of #429, removing the erroneous multiplication by 1024 in TidStoreCreate while leaving the rest of the series pending.

  • John Naylorsaw the final versiontrailerIdentified the byte/kilobyte mistake in #428 and explicitly accepted the attached fix in #436.
Fix potential integer handling issue in radixtree.h.
25 Mar 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #4311 of 1 reviewer saw the final version

Implements #431 but moves Assert(shift == 0) immediately after the loop, as requested in #432; changed-line similarity alone misses this relocation.

  • Tom Lanesaw the final versiontrailerExplained the Coverity finding in #430 and reviewed the fix with an assertion-placement correction in #432.
Add TIDStore, to store sets of TIDs (ItemPointerData) efficiently.
21 Mar 2024Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #418

Takes TidStore and its tests from #418, leaving vacuum integration; final edits include test locking/output cleanup, .gitignore, and removal of an unnecessary include, described in #422.

Fix link error for test_radixtree module on Windows
8 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: pgsql: Add template for adaptive radix tree (modified before commit)
Fix link error for test_radixtree module on Windows
8 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Derives from Sawada's inline Windows-only linking fix in #392; John changed the library to pgport_shlib and tested that adjustment in #394.

  • John Naylorsaw the final versioncommittercommitted the patch
Blind attempt to fix ODR violations
7 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Removes test_radixtree's link_with: pgport_srv directive as proposed inline in #386 and tested in #387, with no matching attached patchset.

  • Masahiko Sawadasaw the final versionLLM analysis, 100% sureConfirmed that the inline linkage removal still built in #387 and is explicitly credited as reviewer in the commit.
Fix incorrect format specifier for int64
7 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #3831 of 1 reviewer saw the final version

The three INT64_FORMAT substitutions in radixtree.h match #383.

  • Masahiko Sawadasaw the final versionLLM analysis, 90% sureReported the precise int64 format failures in #382 before submission and commit; his later approval in #384 is not used as pre-commit evidence.
Fix redefinition of typedefs
7 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Implements Sawada's inline patch in #379, replacing duplicate RT_RADIX_TREE and RT_ITER typedef definitions with struct definitions.

  • John Naylorsaw the final versioncommittercommitted the patch
Add template for adaptive radix tree
7 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 89% surepart of a posted patchsetsignificant changesfrom patchset #2590 of 1 reviewer saw the final version

The radix component descends from the last indexed full implementation in #259, with extensive later changes to nodes, variable-length values, locking, and tests; the final archive submission is described in #372. The commit names both Sawada and source sender Naylor as authors.

  • Andres Freundsaw an earlier versionLLM analysis, 99% sureReviewed representation and performance in #61 and #66 and reported portability failures in #135, before major subsequent reworking.
Fix signedness error in 9f225e992 for gcc
6 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #3691 of 1 reviewer saw the final version

Exactly applies the signed-vector cast supplied in #369 to the ARM vshrq_n_s8 call.

  • Masahiko Sawadasaw the final versionLLM analysis, 100% sureReproduced the GCC failure and verified the patch and radix regression tests on Raspberry Pi in #370.
Introduce helper SIMD functions for small byte arrays
6 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #2591 of 2 reviewers saw the final version

Takes the SIMD-helper component carried in #259, with formatting and a rewritten ARM mask comment; the commit credits Sawada, whose helper implementation appeared in #108.

  • Nathan Bossartsaw an earlier versionLLM analysis, 94% sureProposed full-capacity SIMD searching with masked excess results in #87 and is explicitly credited by the commit, although the helper interface was subsequently reworked.
  • John Naylorsaw the final versioncommittercommitted the patch

Credits across 20 commits

Author
Masahiko SawadaLLM8
John NaylorLLM7
Andres FreundLLM1
David RowleyLLM1
Noah Misch1
Reviewer
John Naylorcommitter10
Dilip Kumar1
Masahiko Sawada1
Tom Lane1
Reported by
David Rowley1
John Naylor1
Noah Misch1
Tom Lane as per coverity1
Co author
John Naylor1
Committer
John Naylor13
Masahiko Sawada7

N LLM means N of the credits come from LLM analysis, not from commit trailers.