Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

Started by Bharath Rupireddyover 4 years ago4 messageshackers
Jump to latest
#1Bharath Rupireddy
bharath.rupireddyforpostgres@gmail.com

Hi,

It looks like the commit d75288fb [1]commit d75288fb27b8fe0a926aaab7d75816f091ecdc27 Author: Fujii Masao <fujii@postgresql.org> Date: Mon Mar 15 13:13:14 2021 +0900 added an unnecessary
Assert(PgArchPID == 0); in PostmasterStateMachine as the if block code
gets hit only when PgArchPID == 0. PSA small patch.

[1]: commit d75288fb27b8fe0a926aaab7d75816f091ecdc27 Author: Fujii Masao <fujii@postgresql.org> Date: Mon Mar 15 13:13:14 2021 +0900
commit d75288fb27b8fe0a926aaab7d75816f091ecdc27
Author: Fujii Masao <fujii@postgresql.org>
Date: Mon Mar 15 13:13:14 2021 +0900

Make archiver process an auxiliary process.

Regards,
Bharath Rupireddy.

Attachments:

v1-0001-Remove-redundant-Assert-PgArchPID-0-inPostmasterS.patchapplication/octet-stream; name=v1-0001-Remove-redundant-Assert-PgArchPID-0-inPostmasterS.patchDownload+0-2
#2Michael Paquier
michael@paquier.xyz
In reply to: Bharath Rupireddy (#1)
Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

On Wed, Jul 14, 2021 at 11:38:59PM +0530, Bharath Rupireddy wrote:

It looks like the commit d75288fb [1] added an unnecessary
Assert(PgArchPID == 0); in PostmasterStateMachine as the if block code
gets hit only when PgArchPID == 0. PSA small patch.

Agreed that there is no need to keep that around. Will fix.
--
Michael

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Michael Paquier (#2)
Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

On 2021/07/15 11:21, Michael Paquier wrote:

On Wed, Jul 14, 2021 at 11:38:59PM +0530, Bharath Rupireddy wrote:

It looks like the commit d75288fb [1] added an unnecessary
Assert(PgArchPID == 0); in PostmasterStateMachine as the if block code
gets hit only when PgArchPID == 0. PSA small patch.

Good catch, Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#4Michael Paquier
michael@paquier.xyz
In reply to: Fujii Masao (#3)
Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine

On Thu, Jul 15, 2021 at 11:49:33AM +0900, Fujii Masao wrote:

Good catch, Thanks!

Done while I was on it.
--
Michael