Doc necessity for superuser privileges to execute pg_import_system_collations()

Started by torikoshiaover 4 years ago3 messages
#1torikoshia
torikoshia@oss.nttdata.com
1 attachment(s)

Hi.

It seems that only superusers can execute pg_import_system_collations(),
but this is not mentioned in the manual.

Since other functions that require superuser privileges describe that in
the manual, I think it would be better to do the same for consistency.

Thoughts?

--
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Attachments:

v1-0001-doc-pg_import_system_collations-needs-superuser.patchtext/x-diff; name=v1-0001-doc-pg_import_system_collations-needs-superuser.patchDownload
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index ac6347a971..819f2c8914 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -26563,6 +26563,7 @@ postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
         be <literal>pg_catalog</literal>, but that is not a requirement; the
         collations could be installed into some other schema as well.  The
         function returns the number of new collation objects it created.
+        This function is restricted to superusers.
        </para></entry>
       </row>
      </tbody>
#2Fujii Masao
masao.fujii@oss.nttdata.com
In reply to: torikoshia (#1)
Re: Doc necessity for superuser privileges to execute pg_import_system_collations()

On 2021/07/19 11:45, torikoshia wrote:

Hi.

It seems that only superusers can execute pg_import_system_collations(), but this is not mentioned in the manual.

Since other functions that require superuser privileges describe that in the manual, I think it would be better to do the same for consistency.

Thoughts?

LGTM.

IMO it's better to back-patch this to v10
where pg_import_system_collations() was added.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#3Fujii Masao
masao.fujii@oss.nttdata.com
In reply to: Fujii Masao (#2)
Re: Doc necessity for superuser privileges to execute pg_import_system_collations()

On 2021/07/19 13:30, Fujii Masao wrote:

On 2021/07/19 11:45, torikoshia wrote:

Hi.

It seems that only superusers can execute pg_import_system_collations(), but this is not mentioned in the manual.

Since other functions that require superuser privileges describe that in the manual, I think it would be better to do the same for consistency.

Thoughts?

LGTM.

IMO it's better to back-patch this to v10
where pg_import_system_collations() was added.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION