postgresql.conf.sample missing units
Hello,
I found that the start section of the postgresql.conf file is missing a
description of two units: bytes (appeared in version 11) and
microseconds (in version 12).
The attached patch makes these changes to the postgresql.conf.sample file.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
Attachments:
add-units-in-sample.patchtext/x-patch; charset=UTF-8; name=add-units-in-sample.patchDownload
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index ccaaf63850..b242a7fc8b 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -24,7 +24,8 @@
# "postgres -c log_connections=on". Some parameters can be changed at run time
# with the "SET" SQL command.
#
-# Memory units: kB = kilobytes Time units: ms = milliseconds
+# Memory units: B = bytes Time units: us = microseconds
+# kB = kilobytes ms = milliseconds
# MB = megabytes s = seconds
# GB = gigabytes min = minutes
# TB = terabytes h = hours
On Mon, Jul 19, 2021 at 5:44 AM Pavel Luzanov <p.luzanov@postgrespro.ru>
wrote:
Hello,
I found that the start section of the postgresql.conf file is missing a
description of two units: bytes (appeared in version 11) and
microseconds (in version 12).The attached patch makes these changes to the postgresql.conf.sample file.
Seems like an oversight. I'll commit this soon barring objections.
--
John Naylor
EDB: http://www.enterprisedb.com
On Mon, Jul 19, 2021 at 10:31 AM John Naylor <john.naylor@enterprisedb.com>
wrote:
On Mon, Jul 19, 2021 at 5:44 AM Pavel Luzanov <p.luzanov@postgrespro.ru>
wrote:
Hello,
I found that the start section of the postgresql.conf file is missing a
description of two units: bytes (appeared in version 11) and
microseconds (in version 12).The attached patch makes these changes to the postgresql.conf.sample
file.
Seems like an oversight. I'll commit this soon barring objections.
I pushed this and backpatched to v12. I also extracted just the "bytes"
part and applied it to v11.
--
John Naylor
EDB: http://www.enterprisedb.com
On 21.07.2021 17:33, John Naylor wrote:
I pushed this and backpatched to v12. I also extracted just the
"bytes" part and applied it to v11.
It's a little more complicated, but it's the right decision.
Thank you.
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company