Jul 2021

2 commits
Add some missing exit() calls in error paths for various binaries
29 Jul 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #102 of 2 reviewers saw the final version

The commit exactly matches five hunks across pg_archivecleanup.c, pg_basebackup.c, pg_recvlogical.c and pgbench.c from #10, excluding only the separately committed pg_verifybackup fix. The retained hunks have no code changes.

  • Robert Haassaw the final versiontrailerRobert judged all fixes reasonable and discussed why exiting after pg_basebackup chmod() failures was preferable despite continued writing being possible #12.
  • Fabien Coelhosaw the final versiontrailerFabien explicitly supported the pgbench exit and considered the other added exits reasonable while qualifying his familiarity with those programs #11.
Add missing exit() in pg_verifybackup when failing to find pg_waldump
29 Jul 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #102 of 2 reviewers saw the final version

The commit exactly matches the single pg_verifybackup.c hunk from #10, adding exit(1) when locating a matching pg_waldump fails. The other four files were split into a separate commit.

  • Robert Haassaw the final versiontrailerRobert reviewed the proposed fixes and identified the cases other than pg_basebackup's chmod() handling as clear bugs #12.
  • Fabien Coelhosaw the final versiontrailerFabien considered the added exits outside pgbench reasonable, with a qualification about his familiarity with those programs #11.

Credits across 2 commits

Author
Michael PaquierLLM2
Reviewer
Fabien COELHO2
Robert Haas2
Committer
Michael Paquier2

N LLM means N of the credits come from LLM analysis, not from commit trailers.