model-writtenrun 6288 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Alvaro Herrera relayed a report from Gabriele Bartolini and team that removing a configuration line failed to set pg_settings.pending_restart, and submitted a one-line fix to set the flag directly when processing removed settings #1.
- Daniel Gustafsson tested configuration changes and reload methods and endorsed the fix; he also noted misleading configuration-error reporting for restart-required changes, explicitly leaving that separate issue outside this patch #2.
- Tom Lane initially objected to increasing the flag's complexity #3, while Alvaro defended the narrow consistency fix and left redesigning the mechanism outside its scope #4.
- Tom then acknowledged misreading the patch, accepted setting the flag, proposed moving the assignment before ereport with an explanatory comment, and requested checking that restoring the removed setting clears the flag #5.
- Alvaro committed the submitted patch with Tom's placement and comment changes as 93a0bf2390, then confirmed that he had adopted the suggestion and tested restoration successfully #6.
- After the commit, Alexander Kukushkin demonstrated that removing an explicitly configured default value could set pending_restart even though the effective value stayed unchanged #7; Tom considered this consistent with the existing restart warning, and the thread ended with the fix landed and no further change addressing that case #8.