Jul 2021

1 commit
Improve libpq's handling of OOM during error message construction.
29 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #120 of 5 reviewers saw the final version

The commit preserves all changes from #12 in src/interfaces/libpq/fe-connect.c, fe-exec.c and libpq-int.h. It additionally handles allocation failures in pqInternalNotice and pqGetErrorNotice3 and fixes an OOM message's missing newline in fe-protocol3.c 514b4c11d2.

  • Nathan Bossartsaw an earlier versionLLM analysis, 100% sureNathan checked the fallback against previous behavior, discussed lost diagnostic context, and approved the initial patch before its architectural replacement #2.
  • Michael Paquiersaw an earlier versionLLM analysis, 98% sureMichael reviewed the diagnostic simplification and backpatch scope and objected to using two helper routines in the initial design #4.
  • Andrew Dunstansaw an earlier versionLLM analysis, 98% sureAndrew endorsed the initial recovery patch and its two-function interface before the design was replaced #5.
  • Andres Freundsaw an earlier versionLLM analysis, 98% sureAndres questioned whether recovery could guarantee a message, suggested preallocation, and inspected gettext's OOM fallback before the redesign #9.
  • Ranier Vilelasaw an earlier versionLLM analysis, 99% sureRanier withdrew his proposed simplification after recognizing the pqResultStrdup failure case and endorsed the revised patch, before the commit added notice-handling logic #13 #17.

Credits across 1 commit

Author
Tom LaneLLM1
Committer
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.