Apr 2022

3 commits
Use Generation memory contexts to store tuples in sorts
4 Apr 2022David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #440 of 1 reviewer saw the final version

This commits the Generation-for-unbounded-sorts component of the series reposted in #44, originally authored in #43. Applying that component to the commit's parent reproduces all four changed files, apart from indentation in src/backend/executor/nodeIncrementalSort.c; the allocator and API components landed separately.

  • Andy Fansaw an earlier versiontrailerIn #36, Andy benchmarked the simple tuplesort change from #1 with growing allocator blocks, before the later bounded-sort policy and API changes.
Adjust tuplesort API to have bitwise option flags
4 Apr 2022David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

This combines the bitwise-options API component and Justin Pryzby's DTrace fix from #44, leaving the allocator and Generation-selection components to separate commits. Applying both attachments to the commit's parent reproduces the implementation, with only comment wrapping differing in src/backend/utils/sort/tuplesort.c.

  • Justin Pryzbysaw the final versiontrailerJustin identified the missed DTrace argument in #43 and supplied the correction in #44, which the commit incorporates.
Improve the generation memory allocator
4 Apr 2022David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #440 of 1 reviewer saw the final version

This commits only the allocator component reposted in #44, credited to David Rowley and Tomas Vondra. Applying it to the commit's parent reproduces the implementation across all four files, with formatting and a GenerationBlockFree comment correction in src/backend/utils/mmgr/generation.c.

  • Andy Fansaw an earlier versiontrailerIn #36, Andy approved and benchmarked Tomas's grow-block component, last submitted in #18, before the keeper allocation and freeblock recycling reworks.

Credits across 3 commits

Author
David Rowley3
Tomas Vondra1
Reviewer
Andy Fan2
Justin Pryzby1
Committer
David Rowley3