Extra code in commit_ts.h
Hi,
I found two extra code lines in commit_ts.h (see attachment).
They confused me during exploring of the code. If they still needed, may
be add some comments?
--
regards,
Andrey Lepikhov
Postgres Professional
Attachments:
excess_code.patchtext/x-patch; charset=UTF-8; name=excess_code.patchDownload
diff --git a/src/include/access/commit_ts.h b/src/include/access/commit_ts.h
index e045dd416f..a1538978c6 100644
--- a/src/include/access/commit_ts.h
+++ b/src/include/access/commit_ts.h
@@ -15,14 +15,10 @@
#include "datatype/timestamp.h"
#include "replication/origin.h"
#include "storage/sync.h"
-#include "utils/guc.h"
extern PGDLLIMPORT bool track_commit_timestamp;
-extern bool check_track_commit_timestamp(bool *newval, void **extra,
- GucSource source);
-
extern void TransactionTreeSetCommitTsData(TransactionId xid, int nsubxids,
TransactionId *subxids, TimestampTz timestamp,
RepOriginId nodeid);
On Tue, 3 Aug 2021 at 21:36, Andrey V. Lepikhov
<a.lepikhov@postgrespro.ru> wrote:
I found two extra code lines in commit_ts.h (see attachment).
They confused me during exploring of the code. If they still needed, may
be add some comments?
Going by:
$ git config --global diff.renamelimit 1000
$ git diff 73c986adde5~1.. | grep check_track_commit_timestamp
+extern bool check_track_commit_timestamp(bool *newval, void **extra,
that function has never been defined.
David
On 3/8/21 15:16, David Rowley wrote:
it diff 73c986adde5~1.. | grep check_track_commit_timestamp
I think this is waste code. May be delete it?
--
regards,
Andrey Lepikhov
Postgres Professional
On Tue, 3 Aug 2021 at 23:12, Andrey Lepikhov <a.lepikhov@postgrespro.ru> wrote:
On 3/8/21 15:16, David Rowley wrote:
it diff 73c986adde5~1.. | grep check_track_commit_timestamp
I think this is waste code. May be delete it?
Yeah, I think it can be safely removed. I can do so unless someone
thinks otherwise.
David