Dec 2021 - Jan 2022

3 commits
postgres_fdw: Add regression test for postgres_fdw.application_name GUC.
7 Jan 2022Fujii Masaomaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: pgsql: postgres_fdw: Allow postgres_fdw.application_name to include esc
LLM analysis, 100% surelanded as postedfrom patchset #853 of 3 reviewers saw the final version

The SQL and expected-output changes match #85 exactly after excluding diff metadata; both use timed pg_terminate_backend and current_setting('max_identifier_length').

  • Masahiko Sawadasaw the final versiontrailerIdentified the truncation-length error in #82 and #84, approved the revision in #86, and explained the termination timeout in #88.
  • Hayato Kurodasaw the final versiontrailerApproved the split tests and timed termination in #81, with only the truncation-length test correction following.
  • Kyotaro Horiguchisaw the final versiontrailerQuestioned shutdown synchronization in #87 and agreed the timeout made it work in #89.
postgres_fdw: Allow postgres_fdw.application_name to include escape sequences.
24 Dec 2021Fujii Masaomaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: [postgres_fdw] add local pid to fallback_application_name (not this thread)
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #682 of 4 reviewers saw the final version

The commit takes the escape-expansion component of #68, removing only the redundant values[i] != NULL check in contrib/postgres_fdw/connection.c apart from rebase and whitespace differences; the separate existing-GUC documentation component had already landed. I disagree with the from_discussion attribution in thread #44616: its July fallback-name proposal supplied background, while this thread's December patchset directly matches the committed implementation, tests, and documentation.

  • Kyotaro Horiguchisaw the final versiontrailerReviewed parser design, padding, and fallback behavior throughout, then reviewed the final null-check decision in #75 and #77.
  • Masahiro Ikedasaw an earlier versiontrailerTested the early escape patch and raised non-ASCII behavior and missing documentation in #13 and #15, before substantial parser redesign.
  • Hou Zhijiesaw an earlier versiontrailerThe acknowledgment in #31 and its abs() cleanup establish a review of #29, although the stripped reply #30 preserves no review text.
  • Fujii Masaosaw the final versiontrailerDirected the implementation and test revisions, supplied #68, and committed the final null-check adjustment as announced in #78.
doc: Add note about postgres_fdw.application_name.
16 Dec 2021Fujii Masaomaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #682 of 2 reviewers saw the final version

Selects only the existing-GUC documentation component of #68; its doc/src/sgml/postgres-fdw.sgml hunk differs solely in indentation. The separate landing is confirmed in #70.

  • Kyotaro Horiguchisaw the final versiontrailerProposed clearer wording for remote-server character restrictions in #56 and agreed to the documentation split in #58, followed by wording-only revisions.
  • Fujii Masaosaw the final versiontrailerRequested the standalone documentation patch in #57, revised its wording and markup, and confirmed committing it in #70.

Sep 2021

2 commits
postgres_fdw: Revert unstable tests for postgres_fdw.application_name.
8 Sep 2021Fujii Masaomaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Deletes the GUC tests from contrib/postgres_fdw/sql/postgres_fdw.sql and its expected output without an attached revert patch. Tom requested removal in #22, and Fujii agreed and diagnosed asynchronous connection shutdown in #23.

  • Tom Lanesaw an earlier versionLLM analysis, 95% sureReported buildfarm failures and proposed the adopted test removal in #22; coverage is earlier against the thread's substantially rewritten final test patch #85.
postgres_fdw: Allow application_name of remote connection to be set via GUC.
7 Sep 2021Fujii Masaomaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #162 of 2 reviewers saw the final version

All six changed files match #16 after excluding diff metadata. Fujii forwarded revisions of Kuroda's GUC patch, and the commit explicitly credits Hayato Kuroda as author.

  • Masahiro Ikedasaw the final versiontrailerReported testing and reading the GUC patch in #13, questioned precedence, and accepted the explanation in #18, with only the ft6 test correction following.
  • Fujii Masaosaw the final versiontrailerProposed the GUC, reviewed its semantics and tests, supplied the last two revisions, and announced committing it in #20.

Credits across 5 commits

Author
Hayato Kuroda (Fujitsu)3
Fujii Masao1
Reviewer
Fujii Masao3
Kyotaro Horiguchi3
Masahiro Ikeda2
Hayato Kuroda (Fujitsu)1
Hou, Zhijie1
Masahiko Sawada1
Reported by
Tom Lane as per buildfarm1
Committer
Fujii Masao5