Aug - Sep 2021

2 commits
Optimize fileset usage in apply worker.
2 Sep 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #761 of 3 reviewers saw the final version

Applying #76 to the commit's parent reproduces all seven committed files byte-for-byte. Amit forwarded Dilip's patch with comment edits, and the patch and commit explicitly credit Dilip.

  • Hou Zhijiesaw an earlier versiontrailerFound memory-cleanup and deletion issues and approved the optimization in #72, but #75 subsequently changed deletion-error handling and fileset storage.
  • Masahiko Sawadasaw an earlier versiontrailerApproved the optimization with a comment correction in #70, before #75 changed deletion-error handling and fileset storage.
  • Amit Kapilasaw the final versiontrailerCorrected cleanup ordering and deletion-error semantics, reviewed #75, supplied #76, and committed the final version.
Refactor sharedfileset.c to separate out fileset implementation.
30 Aug 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #683 of 3 reviewers saw the final version

The commit takes only the refactor component of the two-patch series in #68; applying that component to the commit's parent reproduces all 14 committed files byte-for-byte. The worker optimization remained for a separate landing, as confirmed in #71.

  • Hou Zhijiesaw the final versiontrailerReviewed API removal and comments in #51, then reported successful parallel hash-join and B-tree tests and requested the typedef entry in #60, after which only light refactor edits followed.
  • Masahiko Sawadasaw the final versiontrailerRequested independent cleanup and clearer documentation in #55, then approved the polished refactor in #62.
  • Amit Kapilasaw the final versiontrailerRequired independently correct cleanup, directed reuse of the existing worker exit hook, polished the refactor in #61, and committed it.

Aug 2021

1 commit
Move temporary file cleanup to before_shmem_exit().
8 Aug 2021Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #150 of 1 reviewer saw the final version

Retains #15's initialization split and early temporary-file cleanup, but removes the fallback on_proc_exit pass and PANIC check, guards the state variable with USE_ASSERT_CHECKING, and adds an initialization assertion. Andres explicitly describes these changes in #18.

  • Tom Lanesaw an earlier versionLLM analysis, 82% sureReproduced the shutdown failure in #6 and challenged the proposed subsystem ordering in #9 and #11, providing design review before the attachment and its later cleanup-hook changes.

Credits across 3 commits

Author
Dilip Kumar2
Andres Freund1
based on suggestion by Andres Freund1
based on suggestion by Thomas Munro1
Reviewer
Amit Kapila2
Hou, Zhijie2
Masahiko Sawada2
Committer
Amit Kapila2
Andres Freund1