Jan 2023

1 commit
Add non-decimal integer support to type numeric.
23 Jan 2023Dean Rasheedmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #551 of 1 reviewer saw the final version

Lands the first component of #55, leaving underscore support for another thread as agreed in #57. Compared with that component, numeric.c gains an explanatory comment and numeric regression tests gain signed-NaN and invalid-digit cases.

  • Peter Eisentrautsaw the final versionLLM analysis, 88% sureExpressed a positive assessment of the numeric extension in #56 before the commit, with only comments and tests subsequently changed.

Dec 2022

2 commits
Non-decimal integer literals
14 Dec 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #530 of 4 reviewers saw the final version

The added and removed lines across all 16 files match #53 exactly; #54 announces the commit.

  • John Naylorsaw an earlier versiontrailerReviewed scanner structure, error locations and overflow tests, then approved #35 in #36, before negative-value, missing-digit and accumulation changes.
  • Zhihong Yusaw an earlier versiontrailerSuggested stronger octal test digits in #4, before subsequent scanner and integer-conversion changes.
  • David Rowleysaw an earlier versiontrailerSupplied the optimization delta in #38, benchmarked #44 in #45, and reported missing-digit acceptance in #48, before the final implementation changes.
  • Dean Rasheedsaw an earlier versiontrailerReported negative-literal failures in #40, found correctness problems in the optimization delta in #46, and proposed revised accumulation in #50, before those changes were incorporated.
Improve performance of pg_strtointNN functions
4 Dec 2022David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: Improve performance of pg_strtointNN functions (modified before commit)

Feb 2022

5 commits
Reject trailing junk after numeric literals
16 Feb 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #181 of 1 reviewer saw the final version

Lands the trailing-junk rejection component of #18. It removes the redundant realfail1 rule, renames the remaining rule and fixes ECPG comment placement exactly as requested in #26 and confirmed in #28.

  • John Naylorsaw the final versiontrailerReviewed the scanner changes in #13 and #26, directly requesting the redundant-rule removal and ECPG comment fix included at commit.
Add test case for trailing junk after numeric literals
15 Feb 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #181 of 1 reviewer saw the final version

Lands only the trailing-junk regression-test component of #18; its changed lines in numerology.sql and numerology.out match exactly.

  • John Naylorsaw the final versiontrailerAssessed the first four components of #18 as straightforward in #26, and this component landed unchanged.
Remove pg_atoi()
15 Feb 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #181 of 1 reviewer saw the final version

Lands only the pg_atoi() removal component of #18, with identical changed lines in int.c, numutils.c and builtins.h.

  • John Naylorsaw the final versiontrailerIncluded this removal in his positive assessment of the first four components in #26, and it landed unchanged.
Remove one use of pg_atoi()
14 Feb 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #181 of 1 reviewer saw the final version

Lands only the jsonpath_gram.y component of #18, replacing pg_atoi() with atoi(); the changed lines match exactly.

  • John Naylorsaw the final versiontrailerIncluded this caller replacement in his assessment of the first four components in #26, and it landed unchanged.
Move scanint8() to numutils.c
14 Feb 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #180 of 1 reviewer saw the final version

Lands the scanint8() relocation and pg_strtoint64() conversion component of #18. The commit additionally clears errno before strtoul() in pgoutput.c and makes the errno comparison explicit.

  • John Naylorsaw an earlier versiontrailerReviewed the relocation positively in #26, but the subsequent errno initialization changes error-handling behavior and has no visible follow-up review.

Dec 2021

2 commits
Remove unused includes
1 Dec 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #111 of 1 reviewer saw the final version

Lands only the unused-includes component of #11, identically removing utils/int8.h from cash.c, formatting.c, numeric.c and rangetypes.c.

  • John Naylorsaw the final versiontrailerExplicitly said the first two components could be pushed in #13, and the include removal landed unchanged.
Improve some comments in scanner files
1 Dec 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #111 of 1 reviewer saw the final version

Lands only the scanner-comment cleanup component of #11, adding 'the' before 'parser' in all three scanners as requested in #13.

  • John Naylorsaw the final versiontrailerReviewed and approved the cleanup in #13, supplying the wording correction used in the commit.

Credits across 10 commits

Author
Peter EisentrautLLM8
Dean Rasheed1 LLM2
David Rowley1
Reviewer
John Naylor8
David Rowley1
Dean Rasheed1
Zhihong Yu1
Committer
Peter Eisentraut8
David Rowley1
Dean Rasheed1

N LLM means N of the credits come from LLM analysis, not from commit trailers.