Sep 2021

2 commits
Remove Value node struct
9 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #62 of 2 reviewers saw the final version

639a86e36a matches the Value-removal patch in #6 except for restoring the DefElem.arg comment in src/include/nodes/parsenodes.h as “typically Integer, Float, String, or TypeName.” Peter confirms that final review adjustment in #8.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIn #3, he welcomed the cleanup and identified the unused Null struct, which #6 removed; subsequent changes were light.
  • Kyotaro Horiguchisaw the final versiontrailerHe identified redundant casts and stale documentation in #5, then clarified the missing DefElem.arg documentation in #7, which was restored before committing.
Remove useless casts
9 Sep 2021Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #62 of 2 reviewers saw the final version

cbdf75bf80 matches the cast-cleanup patch in #6, removing 28 redundant Value-pointer casts across five files without additional edits.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIn #3, he assessed the cleanup positively overall, although his specific finding concerned the companion Value-removal patch; the cast cleanup subsequently changed only through rebasing.
  • Kyotaro Horiguchisaw the final versiontrailerHe explicitly said the cast-cleanup patch looked fine in #5, and its implementation remained unchanged in #6.

Credits across 2 commits

Author
Peter EisentrautLLM2
Reviewer
Dagfinn Ilmari Mannsåker2
Kyotaro Horiguchi2
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.