Mar 2022

1 commit
Close race condition in slot_creation_error.spec.
19 Mar 2022Noah Mischmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #172 of 2 reviewers saw the final version

The diffs in contrib/test_decoding/specs/slot_creation_error.spec and its expected output match #17 exactly after normalizing index metadata.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 100% sureConfirmed that #17 looked correct and worked in testing in #18, and the commit explicitly credits his review.
  • Andres Freundsaw the final versionLLM analysis, 100% sureAnalyzed the isolationtester race and endorsed #17 in #19, and the commit explicitly credits his review.

Feb 2022

2 commits
Add isolation test for errors during logical slot creation.
15 Feb 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #132 of 2 reviewers saw the final version

Matches the three-file isolation test in #13, except BEGIN ISOLATION LEVEL SERIALIZABLE becomes BEGIN in the specification and its three expected-output occurrences.

  • Kyotaro Horiguchisaw the final versionLLM analysis, 98% sureEndorsed the proposed isolation-test direction in #14 before the commit, with only a light test adjustment following.
  • Masahiko Sawadasaw the final versionLLM analysis, 86% sureGave a pre-commit +1 in #15 during discussion of the isolation test attached in #13.
Move replication slot release to before_shmem_exit().
15 Feb 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #122 of 2 reviewers saw the final version

Preserves the implementation from #12, moving a static declaration in src/backend/replication/slot.c and polishing comments in postgres.c and postinit.c, including the pgstat initialization-order explanation.

  • Kyotaro Horiguchisaw the final versiontrailerQuestioned dynamic registration in #6, then reviewed #10 as fine with cosmetic suggestions in #11, after which only light changes followed.
  • Andres Freundsaw the final versiontrailerRecommended BaseInit() registration in #7 and committed #12 with minor polishing, as reported in #13.

Credits across 3 commits

Author
Andres FreundLLM1
Masahiko Sawada1
Noah MischLLM1
Reviewer
Andres Freund1
Kyotaro Horiguchi1
Committer
Andres Freund2
Noah Misch1

N LLM means N of the credits come from LLM analysis, not from commit trailers.