Jan 2022

3 commits
Introduce log_destination=jsonlog
17 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #351 of 2 reviewers saw the final version

Matches the JSON implementation in #35 with light edits to comments, formatting, copyright, and documentation, including pg_current_logfile() in doc/src/sgml/func.sgml. The commit credits Sehrope Sarkuni and Michael Paquier, and #36 confirms the final adjustments.

  • Nathan Bossartsaw the final versiontrailerIn #34, Nathan reported reviewing the latest series and exercising jsonlog successfully; only light changes followed.
  • Justin Pryzbyno review foundtrailerJustin is credited by the commit, but the supplied thread contains no message or review activity from him.
Move any code specific to log_destination=csvlog to its own file
12 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #331 of 1 reviewer saw the final version

Lands the CSV-extraction component of #33, moving CSV-specific code into src/backend/utils/error/csvlog.c. Differences are a copyright update and removal of unnecessary timestamp temporaries, with context adjusted for the preceding elog commit.

  • Nathan Bossartsaw the final versiontrailerNathan explicitly described the two refactoring patches as straightforward and uncontroversial in #34.
Refactor set of routines specific to elog.c
12 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #331 of 1 reviewer saw the final version

Lands the first component of #33, exposing shared elog routines in src/include/utils/elog.h. Final cleanup replaces direct timestamp resets with the equivalent helper, removes temporary variables, and adjusts formatting.

  • Nathan Bossartsaw the final versiontrailerNathan reviewed the latest series and specifically endorsed the refactoring components in #34.

Sep - Oct 2021

3 commits
Fix compilation warning in syslogger.c
7 Oct 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #231 of 1 reviewer saw the final version

Exactly matches Nathan Bossart's one-line initialization of logFileExt to NULL in src/backend/postmaster/syslogger.c from #23.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Refactor per-destination file rotation in logging collector
7 Oct 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #22

Lands the rotation component of #22; applying that attachment to the commit's parent confirms only a forward declaration, comment edits, and formatting differences in syslogger.c. The elog and JSON components remain separate.

Refactor output file handling when forking syslogger under EXEC_BACKEND
29 Sep 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #20

Lands the descriptor-handling component of #20, leaving file rotation for later. syslogger_fdget() and its callers change from long/%ld to int/%d after the Windows handle analysis and testing reported in #21.

Sep 2021

2 commits
Add regression tests for csvlog with the logging collector
13 Sep 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #12

The diff exactly matches #12, adding CSV coverage and reusable helpers to src/bin/pg_ctl/t/004_logrotate.pl. The commit credits Michael Paquier and Sehrope Sarkuni.

Refactor the syslogger pipe protocol to use a bitmask for its options
13 Sep 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #100 of 2 reviewers saw the final version

The diff exactly matches #10, including bits8 protocol flags and pg_popcount() destination validation. The commit credits Michael Paquier and Sehrope Sarkuni and acknowledges Andrew Dunstan and Greg Stark's discussion.

  • Andrew Dunstansaw an earlier versionLLM analysis, 93% sureAndrew proposed encoding destination and end-marker information within one byte in #6, before the bitmask redesign and stricter validation.
  • Greg Starksaw an earlier versionLLM analysis, 77% sureGreg argued for extensible format/channel encoding in #8, which Michael related to #7 in #9, before stricter header validation was added.

Credits across 8 commits

Author
Michael Paquier7
Sehrope Sarkuni6
Nathan Bossart1
Reviewer
Nathan Bossart3
Justin Pryzby1
Michael Paquiercommitter1
Committer
Michael Paquier8