Fix typo in comments

Started by houzj.fnst@fujitsu.comover 4 years ago3 messages
#1houzj.fnst@fujitsu.com
houzj.fnst@fujitsu.com
1 attachment(s)

Hi,

When reviewing other patches, I noticed two typos:

1.
src/backend/parser/gram.y
ALTER TABLE <name> ALTER [COLUMN] <colname> RESET ( column_parameter = value [, ... ] )

RESET cannot specify value.

2.
src/backend/utils/adt/xid8funcs.c
* Same as pg_current_xact_if_assigned() but doesn't assign a new xid if there

pg_current_xact_if_assigned() should be pg_current_xact_id()

Best regards,
Hou zhijie

Attachments:

0001-fix-typo-in-comments.patchapplication/octet-stream; name=0001-fix-typo-in-comments.patchDownload
From 0706bee3887ead2cf6dc33114b19efc68305ce3b Mon Sep 17 00:00:00 2001
From: "Hou Zhijie" <houzj.fnst@cn.fujitsu.com>
Date: Thu, 2 Sep 2021 19:48:00 +0800
Subject: [PATCH] fix typo in comments

---
 src/backend/parser/gram.y         | 2 +-
 src/backend/utils/adt/xid8funcs.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 39a2849..ee52036 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -2284,7 +2284,7 @@ alter_table_cmd:
 					n->def = (Node *) $5;
 					$$ = (Node *)n;
 				}
-			/* ALTER TABLE <name> ALTER [COLUMN] <colname> RESET ( column_parameter = value [, ... ] ) */
+			/* ALTER TABLE <name> ALTER [COLUMN] <colname> RESET ( column_parameter [, ... ] ) */
 			| ALTER opt_column ColId RESET reloptions
 				{
 					AlterTableCmd *n = makeNode(AlterTableCmd);
diff --git a/src/backend/utils/adt/xid8funcs.c b/src/backend/utils/adt/xid8funcs.c
index cc2b4ac..f1870a7 100644
--- a/src/backend/utils/adt/xid8funcs.c
+++ b/src/backend/utils/adt/xid8funcs.c
@@ -369,7 +369,7 @@ pg_current_xact_id(PG_FUNCTION_ARGS)
 }
 
 /*
- * Same as pg_current_xact_if_assigned() but doesn't assign a new xid if there
+ * Same as pg_current_xact_id() but doesn't assign a new xid if there
  * isn't one yet.
  */
 Datum
-- 
2.7.2.windows.1

#2Fujii Masao
masao.fujii@oss.nttdata.com
In reply to: houzj.fnst@fujitsu.com (#1)
Re: Fix typo in comments

On 2021/09/02 20:54, houzj.fnst@fujitsu.com wrote:

Hi,

When reviewing other patches, I noticed two typos:

Thanks! Both fixes look good to me.
Barring any objection, I will commit the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#3Fujii Masao
masao.fujii@oss.nttdata.com
In reply to: Fujii Masao (#2)
Re: Fix typo in comments

On 2021/09/02 21:47, Fujii Masao wrote:

On 2021/09/02 20:54, houzj.fnst@fujitsu.com wrote:

Hi,

When reviewing other patches, I noticed two typos:

Thanks! Both fixes look good to me.
Barring any objection, I will commit the patch.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION