Dec 2021

3 commits
psql: initialize comment-begin setting to a useful value by default.
1 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #153 of 3 reviewers saw the final version

The commit takes only the Readline component of the three-patch submission in #15. Its src/bin/psql/input.c diff matches that component exactly, which also appeared unchanged in #7.

  • Laurenz Albesaw the final versionLLM analysis, 98% sureLaurenz called the proposed M-# fix a clear improvement in #10, and that patch remained unchanged in #15.
  • Greg Nancarrowsaw the final versionLLM analysis, 98% sureGreg reported testing the submitted collection and said the patches looked good in #16.
  • Alvaro Herrerasaw the final versionLLM analysis, 100% sureAlvaro tested the collection and confirmed that its behavior matched his expectations in #17.
psql: treat "--" comments between queries as separate history entries.
1 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #152 of 4 reviewers saw the final version

The commit takes only the history-flushing component of #15, with an identical src/bin/psql/mainloop.c diff. Its commit message credits Greg Nancarrow, whose original implementation in #1 Tom simplified before posting the final series.

  • David G. Johnstonsaw an earlier versionLLM analysis, 87% sureDavid challenged the original patch's behavior on statement-oriented history grounds in #2, before the history-flushing condition was reworked in #15.
  • Laurenz Albesaw an earlier versionLLM analysis, 80% sureLaurenz endorsed the original patch's behavior while explicitly disclaiming implementation scrutiny in #3, before the logic was simplified in #15.
  • Alvaro Herrerasaw the final versionLLM analysis, 100% sureAlvaro proposed separating leading dash-dash comments from queries in #12 and confirmed successful testing of the final collection in #17.
  • Tom Lanesaw the final versioncommittercommitted the patch
psql: include intra-query "--" comments in what's sent to the server.
1 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #152 of 2 reviewers saw the final version

The commit takes only the intra-query-comment component of #15, including src/fe_utils/psqlscan.l and four expected-output files. All hunks match that component modulo index hashes and a scanner hunk's line offset.

  • Greg Nancarrowsaw the final versionLLM analysis, 98% sureGreg reported testing the collection and said the patches looked good in #16.
  • Alvaro Herrerasaw the final versionLLM analysis, 100% sureAlvaro tested the final collection and endorsed its overall comment-handling behavior in #17.

Credits across 3 commits

Author
Tom LaneLLM2
Greg NancarrowLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.