model-writtenrun 5925 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Greg Nancarrow proposed separate history entries for leading whitespace and dash-dash comments, fixing cases where HISTCONTROL=ignorespace also suppressed the following query's history entry #1.
- David G. Johnston defended the existing statement-oriented behavior #2, while Laurenz Albe supported Greg's proposed behavior as more useful #3.
- Alvaro Herrera raised the related problem that Readline's M-# command inserts a non-SQL comment marker #5, prompting Tom Lane to post an independent patch setting the default marker to '-- ' #7.
- Tom initially objected that immediate history entries could record text never sent to the server and highlighted the separate problem of psql stripping dash-dash comments #6.
- Returning in November, Tom found that preserving all comments caused widespread regression-output changes by including leading comment lines in server error locations; he also recognized that existing history already differed from server input and reconsidered his objection to Greg's approach #9.
- Laurenz reproduced the ignorespace failure and endorsed the Readline fix #10, and Tom explained that separating the leading comment into its own history entry would resolve the failure #11.
- Alvaro proposed treating leading dash-dash comments separately while retaining slash-star comments with the following query #12, a distinction consistent with Tom's experiments #14.
- Tom posted three patches preserving comments only within queries, simplifying Greg's history fix to test whether the query buffer was empty, and retaining the earlier Readline patch unchanged; leading dash-dash comments remained suppressed from server input to avoid excessive behavioral changes #15.
- Greg verified that the collection fixed all four originally reported cases #16, and Alvaro tested and endorsed its overall behavior #17.
- A reported CRLF attachment problem was traced to downloading through Gmail on Windows rather than to the posted patches #18 #19; the ensuing MIME-type discussion produced no patch changes #21 #22 #23 #24.
- Tom committed the intra-query-comment component unchanged apart from rebase offsets as 83884682f4, the history component unchanged as c2f654930e, and the Readline component unchanged as 3d858af07e, all from #15.
- Tom's final message confirmed that the patches had been pushed, leaving all three submitted components committed and no remaining patch under review #25.