Use "superuser" instead of "super user" in code comments
Hi,
It seems like we use "superuser" as a standard term across the entire
code base i.e. error messages, docs, code comments. But there are
still a few code comments that use the term "super user". Can we
replace those with "superuser"? Attaching a tiny patch to do that.
Thoughts?
Regards,
Bharath Rupireddy.
Attachments:
v1-0001-Use-superuser-instead-of-super-user-in-code-comme.patchapplication/octet-stream; name=v1-0001-Use-superuser-instead-of-super-user-in-code-comme.patchDownload+4-5
On 7 Sep 2021, at 14:44, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
It seems like we use "superuser" as a standard term across the entire
code base i.e. error messages, docs, code comments. But there are
still a few code comments that use the term "super user". Can we
replace those with "superuser"? Attaching a tiny patch to do that.
Good catch, superuser is the term we should use for this. There is one
additional “super user” in src/test/regress/sql/conversion.sql (and its
corresponding resultfile) which can be included in this. Unless there are
objections I’ll apply this with the testfile fixup.
--
Daniel Gustafsson https://vmware.com/
On Tue, Sep 7, 2021 at 6:40 PM Daniel Gustafsson <daniel@yesql.se> wrote:
On 7 Sep 2021, at 14:44, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
It seems like we use "superuser" as a standard term across the entire
code base i.e. error messages, docs, code comments. But there are
still a few code comments that use the term "super user". Can we
replace those with "superuser"? Attaching a tiny patch to do that.Good catch, superuser is the term we should use for this. There is one
additional “super user” in src/test/regress/sql/conversion.sql (and its
corresponding resultfile) which can be included in this. Unless there are
objections I’ll apply this with the testfile fixup.
Thanks for picking this up. Here's v2 including the change in
conversion.sql and .out.
Regards,
Bharath Rupireddy.
Attachments:
v2-0001-Use-superuser-instead-of-super-user-in-code-comme.patchapplication/octet-stream; name=v2-0001-Use-superuser-instead-of-super-user-in-code-comme.patchDownload+6-5
On 7 Sep 2021, at 15:48, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
On Tue, Sep 7, 2021 at 6:40 PM Daniel Gustafsson <daniel@yesql.se> wrote:
On 7 Sep 2021, at 14:44, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
It seems like we use "superuser" as a standard term across the entire
code base i.e. error messages, docs, code comments. But there are
still a few code comments that use the term "super user". Can we
replace those with "superuser"? Attaching a tiny patch to do that.Good catch, superuser is the term we should use for this. There is one
additional “super user” in src/test/regress/sql/conversion.sql (and its
corresponding resultfile) which can be included in this. Unless there are
objections I’ll apply this with the testfile fixup.Thanks for picking this up. Here's v2 including the change in
conversion.sql and .out.
Done, thanks!
--
Daniel Gustafsson https://vmware.com/