Regression in PG14 LookupFuncName

Started by Sven Klemmover 4 years ago3 messages
#1Sven Klemm
sven@timescale.com

Hi hackers,

In PG12 and PG13 LookupFuncName would return procedures as well as
functions while in PG14 since commit e56bce5d [0]https://github.com/postgres/postgres/commit/e56bce5d it would disregard
all procedures
and not return them as match.

Is this intended behaviour or an unintended side effect of the refactoring?

Sven

[0]: https://github.com/postgres/postgres/commit/e56bce5d

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Sven Klemm (#1)
Re: Regression in PG14 LookupFuncName

Sven Klemm <sven@timescale.com> writes:

In PG12 and PG13 LookupFuncName would return procedures as well as
functions while in PG14 since commit e56bce5d [0] it would disregard
all procedures
and not return them as match.
Is this intended behaviour or an unintended side effect of the refactoring?

It was intentional, because all internal callers of LookupFuncName only
want to see functions. See the last few messages in the referenced
discussion thread:

/messages/by-id/3742981.1621533210@sss.pgh.pa.us

You should be able to use LookupFuncWithArgs if you want a different
definition.

regards, tom lane

#3Sven Klemm
sven@timescale.com
In reply to: Tom Lane (#2)
Re: Regression in PG14 LookupFuncName

It was intentional, because all internal callers of LookupFuncName only
want to see functions. See the last few messages in the referenced
discussion thread:

/messages/by-id/3742981.1621533210@sss.pgh.pa.us

Thank you for the clarification.

--
Regards, Sven Klemm