a comment in joinrel.c: compute_partition_bounds()
Hi,
I think there's a word missing in the following comment:
/*
* See if the partition bounds for inputs are exactly the same, in
* which case we don't need to work hard: the join rel have the same
* partition bounds as inputs, and the partitions with the same
* cardinal positions form the pairs.
": the join rel have the same..." seems to be missing a "will".
Attached a patch to fix.
--
Amit Langote
EDB: http://www.enterprisedb.com
Attachments:
comment-missing-word.patchapplication/octet-stream; name=comment-missing-word.patchDownload
diff --git a/src/backend/optimizer/path/joinrels.c b/src/backend/optimizer/path/joinrels.c
index 8b69870cf4..798bb23b15 100644
--- a/src/backend/optimizer/path/joinrels.c
+++ b/src/backend/optimizer/path/joinrels.c
@@ -1619,8 +1619,8 @@ compute_partition_bounds(PlannerInfo *root, RelOptInfo *rel1,
/*
* See if the partition bounds for inputs are exactly the same, in
- * which case we don't need to work hard: the join rel have the same
- * partition bounds as inputs, and the partitions with the same
+ * which case we don't need to work hard: the join rel will have the
+ * same partition bounds as inputs, and the partitions with the same
* cardinal positions form the pairs.
*
* Note: even in cases where one or both inputs have merged bounds, it
Hi Amit-san,
On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
I think there's a word missing in the following comment:
/*
* See if the partition bounds for inputs are exactly the same, in
* which case we don't need to work hard: the join rel have the same
* partition bounds as inputs, and the partitions with the same
* cardinal positions form the pairs.": the join rel have the same..." seems to be missing a "will".
Attached a patch to fix.
Good catch! Will fix.
Thanks!
Best regards,
Etsuro Fujita
On Fri, Sep 24, 2021 at 4:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
I think there's a word missing in the following comment:
/*
* See if the partition bounds for inputs are exactly the same, in
* which case we don't need to work hard: the join rel have the same
* partition bounds as inputs, and the partitions with the same
* cardinal positions form the pairs.": the join rel have the same..." seems to be missing a "will".
Attached a patch to fix.
Good catch! Will fix.
Rereading the comment, I think it would be better to add “will” to the
second part “the partitions with the same cardinal positions form the
pairs” as well. Updated patch attached.
Best regards,
Etsuro Fujita
Attachments:
comment-missing-word-2.patchapplication/octet-stream; name=comment-missing-word-2.patchDownload
diff --git a/src/backend/optimizer/path/joinrels.c b/src/backend/optimizer/path/joinrels.c
index 8b69870cf4..16cc9269ef 100644
--- a/src/backend/optimizer/path/joinrels.c
+++ b/src/backend/optimizer/path/joinrels.c
@@ -1619,9 +1619,9 @@ compute_partition_bounds(PlannerInfo *root, RelOptInfo *rel1,
/*
* See if the partition bounds for inputs are exactly the same, in
- * which case we don't need to work hard: the join rel have the same
- * partition bounds as inputs, and the partitions with the same
- * cardinal positions form the pairs.
+ * which case we don't need to work hard: the join rel will have the
+ * same partition bounds as inputs, and the partitions with the same
+ * cardinal positions will form the pairs.
*
* Note: even in cases where one or both inputs have merged bounds, it
* would be possible for both the bounds to be exactly the same, but
Fujita-san,
On Wed, Oct 6, 2021 at 5:41 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
On Fri, Sep 24, 2021 at 4:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
I think there's a word missing in the following comment:
/*
* See if the partition bounds for inputs are exactly the same, in
* which case we don't need to work hard: the join rel have the same
* partition bounds as inputs, and the partitions with the same
* cardinal positions form the pairs.": the join rel have the same..." seems to be missing a "will".
Attached a patch to fix.
Good catch! Will fix.
Rereading the comment, I think it would be better to add “will” to the
second part “the partitions with the same cardinal positions form the
pairs” as well. Updated patch attached.
No objection from my side.
Thank you.
--
Amit Langote
EDB: http://www.enterprisedb.com
On Thu, Oct 7, 2021 at 12:05 PM Amit Langote <amitlangote09@gmail.com> wrote:
On Wed, Oct 6, 2021 at 5:41 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
Rereading the comment, I think it would be better to add “will” to the
second part “the partitions with the same cardinal positions form the
pairs” as well. Updated patch attached.No objection from my side.
Ok, pushed. Thanks!
Best regards,
Etsuro Fujita