Oct 2021

2 commits
Fix check for trapping exit() calls in libpq
4 Oct 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Restores nm -A in src/interfaces/libpq/Makefile after Anton Voloshin identified the accidental -a substitution in #5. Neither attachment contains this correction; Daniel Gustafsson explained and promised the fix in #8.

  • Anton Voloshinsaw the final versionLLM analysis, 100% sureIdentified the unintended nm option change in #5 before the corrective commit, which also credits him as Reported-by.
Provide error hint on exit() check when building libpq
4 Oct 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #31 of 1 reviewer saw the final version

Matches the conditional shell check in #3, including nm -a, but changes the diagnostic to 'libpq must not be calling any function which invokes exit'. Daniel Gustafsson confirmed the wording edit and push in #4; the commit credits Rachel Heaton and co-author Jacob Champion.

  • Daniel Gustafssonsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Rachel Heaton1
Reviewer
Daniel Gustafssoncommitter1
Reported by
Anton Voloshin1
Co author
Jacob Champion1
Committer
Daniel Gustafsson2