reindexdb usage message about system catalogs

Started by Magnus Haganderover 4 years ago3 messageshackers
Jump to latest
#1Magnus Hagander
magnus@hagander.net

Reindexdb help has this for selection of what to reindex:

-s, --system reindex system catalogs
-S, --schema=SCHEMA reindex specific schema(s) only
-t, --table=TABLE reindex specific table(s) only

Is there a reason the "only" is missing from the -s option? AFAIK that's
what it means, so the attached patch should be correct?

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

Attachments:

reindexdb_usage.patchtext/x-patch; charset=US-ASCII; name=reindexdb_usage.patchDownload+2-2
#2Michael Paquier
michael@paquier.xyz
In reply to: Magnus Hagander (#1)
Re: reindexdb usage message about system catalogs

On Tue, Sep 28, 2021 at 04:15:22PM +0200, Magnus Hagander wrote:

Is there a reason the "only" is missing from the -s option? AFAIK that's
what it means, so the attached patch should be correct?

I cannot think of a reason. This seems historically inherited from
pg_dump, and the option got added when the tool was moved from
contrib/ to src/bin/ as of 85e9a5a.
--
Michael

#3Magnus Hagander
magnus@hagander.net
In reply to: Michael Paquier (#2)
Re: reindexdb usage message about system catalogs

On Wed, Sep 29, 2021 at 5:10 AM Michael Paquier <michael@paquier.xyz> wrote:

On Tue, Sep 28, 2021 at 04:15:22PM +0200, Magnus Hagander wrote:

Is there a reason the "only" is missing from the -s option? AFAIK that's
what it means, so the attached patch should be correct?

I cannot think of a reason. This seems historically inherited from
pg_dump, and the option got added when the tool was moved from
contrib/ to src/bin/ as of 85e9a5a.

Thanks for the double check! Seems I forgot about this one, but I've
backpatched and pushed it now.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;