reindexdb usage message about system catalogs
Reindexdb help has this for selection of what to reindex:
-s, --system reindex system catalogs
-S, --schema=SCHEMA reindex specific schema(s) only
-t, --table=TABLE reindex specific table(s) only
Is there a reason the "only" is missing from the -s option? AFAIK that's
what it means, so the attached patch should be correct?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
Attachments:
reindexdb_usage.patchtext/x-patch; charset=US-ASCII; name=reindexdb_usage.patchDownload
diff --git a/doc/src/sgml/ref/reindexdb.sgml b/doc/src/sgml/ref/reindexdb.sgml
index 80a7f84886..8cb8bf4fa3 100644
--- a/doc/src/sgml/ref/reindexdb.sgml
+++ b/doc/src/sgml/ref/reindexdb.sgml
@@ -208,7 +208,7 @@ PostgreSQL documentation
<term><option>--system</option></term>
<listitem>
<para>
- Reindex database's system catalogs.
+ Reindex database's system catalogs only.
</para>
</listitem>
</varlistentry>
diff --git a/src/bin/scripts/reindexdb.c b/src/bin/scripts/reindexdb.c
index a0b0250c49..64fbb40baf 100644
--- a/src/bin/scripts/reindexdb.c
+++ b/src/bin/scripts/reindexdb.c
@@ -798,7 +798,7 @@ help(const char *progname)
printf(_(" -i, --index=INDEX recreate specific index(es) only\n"));
printf(_(" -j, --jobs=NUM use this many concurrent connections to reindex\n"));
printf(_(" -q, --quiet don't write any messages\n"));
- printf(_(" -s, --system reindex system catalogs\n"));
+ printf(_(" -s, --system reindex system catalogs only\n"));
printf(_(" -S, --schema=SCHEMA reindex specific schema(s) only\n"));
printf(_(" -t, --table=TABLE reindex specific table(s) only\n"));
printf(_(" --tablespace=TABLESPACE tablespace where indexes are rebuilt\n"));
On Tue, Sep 28, 2021 at 04:15:22PM +0200, Magnus Hagander wrote:
Is there a reason the "only" is missing from the -s option? AFAIK that's
what it means, so the attached patch should be correct?
I cannot think of a reason. This seems historically inherited from
pg_dump, and the option got added when the tool was moved from
contrib/ to src/bin/ as of 85e9a5a.
--
Michael
On Wed, Sep 29, 2021 at 5:10 AM Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Sep 28, 2021 at 04:15:22PM +0200, Magnus Hagander wrote:
Is there a reason the "only" is missing from the -s option? AFAIK that's
what it means, so the attached patch should be correct?I cannot think of a reason. This seems historically inherited from
pg_dump, and the option got added when the tool was moved from
contrib/ to src/bin/ as of 85e9a5a.
Thanks for the double check! Seems I forgot about this one, but I've
backpatched and pushed it now.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>