Nov 2021

1 commit
Improve psql tab completion for COMMENT
5 Nov 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #151 of 4 reviewers saw the final version

Both hunks in src/bin/psql/tab-complete.c match #15 after ignoring whitespace and base offsets; the only content differences are spaces between COMMENT object-list entries. Michael Paquier confirms applying this version after formatting fixes in #16.

  • Fujii Masaosaw an earlier versiontrailerIn #13, he identified duplicate text-search queries and questioned operator class/family completion, leading to query replacement and feature removal in #14.
  • Shinya Katosaw an earlier versiontrailerHe proposed broader coverage in #4, reported broken operator quoting in #7, supplied cosmetic fixes in #9, and proposed PROCEDURAL LANGUAGE completion in #11, before subsequent query and scope changes.
  • Suraj Khamkarsaw an earlier versiontrailerHe reviewed formatting in #2 and #5, endorsed object-list ordering and broader completion coverage, and was followed by substantial additions and later simplification.
  • Michael Paquiersaw the final versiontrailerHe questioned procedural-language and operator completion in #10 and #12, then reviewed and committed the final submission with formatting fixes as reported in #16.

Credits across 1 commit

Author
Ken Kato1
Reviewer
Fujii Masao1
Michael Paquier1
Shinya Kato1
Suraj Khamkar1
Committer
Michael Paquier1