pg_stat_replication_slots docs

Started by Amit Kapilaover 4 years ago2 messages

amit.kapila16@gmail.com

over 4 years ago

1 attachment(s)

Today, I noticed that we have mentioned pg_stat_replication_slots
under "Dynamic Statistics Views". I think it should be under
"Collected Statistics Views"?

--
With Regards,
Amit Kapila.

Attachments:

fix_pg_stat_replication_slots_doc.patchapplication/octet-stream; name=fix_pg_stat_replication_slots_doc.patchDownload

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 2cd8920645..7355835202 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -319,15 +319,6 @@ postgres   27093  0.0  0.0  30096  2752 ?        Ss   11:34   0:00 postgres: ser
       </entry>
      </row>
 
-     <row>
-      <entry><structname>pg_stat_replication_slots</structname><indexterm><primary>pg_stat_replication_slots</primary></indexterm></entry>
-      <entry>One row per replication slot, showing statistics about
-       the replication slot's usage.
-       See <link linkend="monitoring-pg-stat-replication-slots-view">
-       <structname>pg_stat_replication_slots</structname></link> for details.
-      </entry>
-     </row>
-
      <row>
       <entry><structname>pg_stat_wal_receiver</structname><indexterm><primary>pg_stat_wal_receiver</primary></indexterm></entry>
       <entry>Only one row, showing statistics about the WAL receiver from
@@ -627,6 +618,15 @@ postgres   27093  0.0  0.0  30096  2752 ?        Ss   11:34   0:00 postgres: ser
       </entry>
      </row>
 
+     <row>
+      <entry><structname>pg_stat_replication_slots</structname><indexterm><primary>pg_stat_replication_slots</primary></indexterm></entry>
+      <entry>One row per replication slot, showing statistics about the
+       replication slot's usage. See
+       <link linkend="monitoring-pg-stat-replication-slots-view">
+       <structname>pg_stat_replication_slots</structname></link> for details.
+      </entry>
+     </row>
+
     </tbody>
    </tgroup>
   </table>

Masahiko Sawada

sawada.mshk@gmail.com

over 4 years ago

In reply to: Amit Kapila (#1)

Re: pg_stat_replication_slots docs

On Thu, Sep 30, 2021 at 3:47 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

Today, I noticed that we have mentioned pg_stat_replication_slots
under "Dynamic Statistics Views". I think it should be under
"Collected Statistics Views"?

Good catch!

Agreed and the patch looks good to me.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/