Jan 2022

3 commits
Make PQcancel use the PGconn's tcp_user_timeout and keepalives settings.
18 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #131 of 3 reviewers saw the final version

Applying both patches from #13 to the commit's parent reproduces all committed code and documentation except two comment edits in src/interfaces/libpq/fe-connect.c. The commit combines the refactoring and socket-option patches and explicitly credits Jelte Fennema as author.

  • Fujii Masaosaw an earlier versionLLM analysis, 100% sureIn #5, Fujii questioned changing the deprecated API and identified duplicated socket-option code; 5987feb70b explicitly credits his review, but substantial implementation changes followed.
  • Andres Freundsaw an earlier versionLLM analysis, 99% sureIn #9, Andres challenged platform divergence and backpatching and requested a helper and separate refactoring, which informed #11 before further Windows and error-handling changes.
  • Tom Lanesaw the final versioncommittercommitted the patch
Avoid calling gettext() in signal handlers.
17 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.2REL_13_STABLE13.6+3 more
LLM analysis, 99% surewritten from the discussion, no matching patch

No attached patch changes src/fe_utils/cancel.c; this commit moves gettext calls into setup_cancel_handler so signal handlers use pretranslated strings. Its discussion trailer cites #14, and its message identifies the fix as a consequence of investigating PQcancel signal safety.

Avoid calling strerror[_r] in PQcancel().
17 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.2REL_13_STABLE13.6+3 more
LLM analysis, 100% surewritten from the discussion, no matching patch

#14 identifies SOCK_STRERROR in PQcancel's error path as unsafe in signal handlers; no attached patch implements its removal. The commit replaces that call in src/interfaces/libpq/fe-connect.c with manual decimal errno formatting.

Credits across 3 commits

Author
Jelte Fennema-NioLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.